Skip to content

Commit 488a71b

Browse files
committed
Update danger (3.4.2) and the changed method names
1 parent 28bc81f commit 488a71b

2 files changed

Lines changed: 6 additions & 10 deletions

File tree

Dangerfile

Lines changed: 4 additions & 8 deletions
Original file line numberDiff line numberDiff line change
@@ -2,20 +2,16 @@
22

33
# Sometimes it's a README fix, or something like that - which isn't relevant for
44
# including in a project's CHANGELOG for example
5-
declared_trivial = pr_title.include? "#trivial"
5+
declared_trivial = github.pr_title.include? "#trivial"
66

77
# Make it more obvious that a PR is a work in progress and shouldn't be merged yet
8-
warn("PR is classed as Work in Progress") if pr_title.include? "[WIP]"
8+
warn("PR is classed as Work in Progress") if github.pr_title.include? "[WIP]"
99

1010
# Warn when there is a big PR
11-
warn("Big PR") if lines_of_code > 500
12-
13-
# Don't let testing shortcuts get into master by accident
14-
fail("fdescribe left in tests") if `grep -r fdescribe specs/`.length > 1
15-
fail("fit left in tests") if `grep -r "fit specs/ `.length > 1
11+
warn("Big PR") if git.lines_of_code > 500
1612

1713
# Add a CHANGELOG entry for app changes
18-
if git.lines_of_code > 50 && !github.modified_files.include?("CHANGELOG.md") && !declared_trivial
14+
if git.lines_of_code > 50 && !git.modified_files.include?("CHANGELOG.md") && !declared_trivial
1915
fail("Please update [CHANGELOG.md](https://github.com/polydice/ICInputAccessory/blob/develop/CHANGELOG.md).")
2016
end
2117

Gemfile.lock

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -8,7 +8,7 @@ GEM
88
tzinfo (~> 1.1)
99
addressable (2.4.0)
1010
claide (1.0.0)
11-
claide-plugins (0.9.1)
11+
claide-plugins (0.9.2)
1212
cork
1313
nap
1414
open4 (~> 1.3)
@@ -48,7 +48,7 @@ GEM
4848
concurrent-ruby (1.0.2)
4949
cork (0.2.0)
5050
colored (~> 1.2)
51-
danger (3.4.0)
51+
danger (3.4.2)
5252
claide (~> 1.0)
5353
claide-plugins (> 0.9.0)
5454
colored (~> 1.2)

0 commit comments

Comments
 (0)