File tree Expand file tree Collapse file tree
Expand file tree Collapse file tree Original file line number Diff line number Diff line change 22
33# Sometimes it's a README fix, or something like that - which isn't relevant for
44# including in a project's CHANGELOG for example
5- declared_trivial = github . pr_title . include? "#trivial"
5+ declared_trivial = ( github . pr_title + github . pr_body ) . include? "#trivial"
66
77# Make it more obvious that a PR is a work in progress and shouldn't be merged yet
8- warn ( "PR is classed as Work in Progress" ) if github . pr_title . include? "[WIP]"
8+ warn "PR is classed as Work in Progress" if github . pr_title . include? "[WIP]"
99
1010# Warn when there is a big PR
11- warn ( "Big PR" ) if git . lines_of_code > 500
11+ warn "Big PR" if git . lines_of_code > 500
12+
13+ # Ensure there is a summary for a PR
14+ fail "Please provide a summary in the Pull Request description" if github . pr_body . length < 5
1215
1316# Add a CHANGELOG entry for app changes
1417if git . lines_of_code > 50 && !git . modified_files . include? ( "CHANGELOG.md" ) && !declared_trivial
15- fail ( "Please update [CHANGELOG.md](https://github.com/polydice/ICInputAccessory/blob/develop/CHANGELOG.md)." )
18+ fail "Please update [CHANGELOG.md](https://github.com/polydice/ICInputAccessory/blob/develop/CHANGELOG.md)." , sticky : true
1619end
1720
1821# Ensure a clean commits history
1922if git . commits . any? { |c | c . message =~ /^Merge branch/ }
20- fail ( ' Please rebase to get rid of the merge commits in this PR' )
23+ fail " Please rebase to get rid of the merge commits in this PR" , sticky : true
2124end
Original file line number Diff line number Diff line change @@ -2,7 +2,7 @@ source "http://rubygems.org"
22ruby "2.3.1"
33
44gem "cocoapods" , "~> 1.1.0"
5- gem "danger" , "~> 3.5 .0"
5+ gem "danger" , "~> 4.0 .0"
66gem "jazzy" , "~> 0.7.0"
77gem "pry"
88gem "rake"
Original file line number Diff line number Diff line change 77 minitest (~> 5.1 )
88 thread_safe (~> 0.3 , >= 0.3.4 )
99 tzinfo (~> 1.1 )
10- addressable (2.4.0 )
10+ addressable (2.5.0 )
11+ public_suffix (~> 2.0 , >= 2.0.2 )
1112 claide (1.0.1 )
1213 claide-plugins (0.9.2 )
1314 cork
4950 colored (1.2 )
5051 cork (0.2.0 )
5152 colored (~> 1.2 )
52- danger (3.5.5 )
53+ danger (4.0.3 )
5354 claide (~> 1.0 )
5455 claide-plugins (>= 0.9.2 )
5556 colored (~> 1.2 )
5657 cork (~> 0.1 )
5758 faraday (~> 0.9 )
5859 faraday-http-cache (~> 1.0 )
5960 git (~> 1 )
60- gitlab (~> 3.7.0 )
6161 kramdown (~> 1.5 )
6262 octokit (~> 4.2 )
6363 terminal-table (~> 1 )
6464 escape (0.0.4 )
65- faraday (0.9.2 )
65+ faraday (0.10.0 )
6666 multipart-post (>= 1.2 , < 3 )
6767 faraday-http-cache (1.3.1 )
6868 faraday (~> 0.8 )
6969 fourflusher (2.0.1 )
7070 fuzzy_match (2.0.4 )
7171 gh_inspector (1.0.2 )
7272 git (1.3.0 )
73- gitlab (3.7.0 )
74- httparty (~> 0.13.0 )
75- terminal-table
76- httparty (0.13.7 )
77- json (~> 1.8 )
78- multi_xml (>= 0.5.2 )
7973 i18n (0.7.0 )
8074 jazzy (0.7.2 )
8175 cocoapods (~> 1.0 )
8781 sqlite3 (~> 1.3 )
8882 xcinvoke (~> 0.2.1 )
8983 json (1.8.3 )
90- kramdown (1.12.0 )
84+ kramdown (1.13.1 )
9185 liferaft (0.0.4 )
9286 method_source (0.8.2 )
9387 minitest (5.9.1 )
9488 molinillo (0.5.2 )
95- multi_xml (0.5.5 )
9689 multipart-post (2.0.0 )
9790 mustache (0.99.8 )
9891 nap (1.1.0 )
9992 netrc (0.7.8 )
100- octokit (4.4.0 )
101- sawyer (~> 0.7 .0 , >= 0.5.3 )
93+ octokit (4.6.2 )
94+ sawyer (~> 0.8 .0 , >= 0.5.3 )
10295 open4 (1.3.4 )
10396 pry (0.10.4 )
10497 coderay (~> 1.1.0 )
10598 method_source (~> 0.8.1 )
10699 slop (~> 3.4 )
100+ public_suffix (2.0.4 )
107101 rake (11.3.0 )
108102 redcarpet (3.3.4 )
109103 rouge (1.11.1 )
110104 sass (3.4.22 )
111- sawyer (0.7.0 )
112- addressable (>= 2.3.5 , < 2.5 )
113- faraday (~> 0.8 , < 0.10 )
105+ sawyer (0.8.1 )
106+ addressable (>= 2.3.5 , < 2.6 )
107+ faraday (~> 0.8 , < 1.0 )
114108 slop (3.6.0 )
115109 sqlite3 (1.3.11 )
116110 terminal-table (1.7.3 )
117111 unicode-display_width (~> 1.1.1 )
118112 thread_safe (0.3.5 )
119113 tzinfo (1.2.2 )
120114 thread_safe (~> 0.1 )
121- unicode-display_width (1.1.1 )
115+ unicode-display_width (1.1.2 )
122116 xcinvoke (0.2.1 )
123117 liferaft (~> 0.0.4 )
124118 xcodeproj (1.3.3 )
@@ -133,7 +127,7 @@ PLATFORMS
133127
134128DEPENDENCIES
135129 cocoapods (~> 1.1.0 )
136- danger (~> 3.5 .0 )
130+ danger (~> 4.0 .0 )
137131 jazzy (~> 0.7.0 )
138132 pry
139133 rake
@@ -143,4 +137,4 @@ RUBY VERSION
143137 ruby 2.3.1p112
144138
145139BUNDLED WITH
146- 1.12.5
140+ 1.13.6
You can’t perform that action at this time.
0 commit comments