add init only config to k8switch ports (#117)

* polycubed: set missing default elements only at initialization time

polycubed fills the default elements on a request if they are missing, this
guarantees that the default elements are always set when the request arrives to
the service implementation, hence the developer has not to take care of it.

When an update (PATCH) request is done those fields should not be set, because
their value will be modified even if the client wanted to update other elements.

Fixes: d8d280c ("Added new REST API and validation code")

Signed-off-by: Mauricio Vasquez B <mauriciovasquezbernal@gmail.com>

* pcn-k8switch: add init-only-config to ports' type

The type attribute in the ports is meant to be only set at creation time.
Use the init-only-config flag on this and remove all the update code for it.

Signed-off-by: Mauricio Vasquez B <mauriciovasquezbernal@gmail.com>

Author: mauriciovasquezbernal

src/services/pcn-k8switch/datamodel/k8switch.yang

@@ -25,6 +25,7 @@ module k8switch {
         }
         mandatory false;
         default DEFAULT;
+        polycube-base:init-only-config;
         description "Type of the LB port (e.g. NODEPORT or DEFAULT)";
       }
     }

src/services/pcn-k8switch/src/Ports.cpp

@@ -34,10 +34,6 @@ void Ports::update(const PortsJsonObject &conf) {
   // the conf JsonObject.
   // You can modify this implementation.
   Port::set_conf(conf.getBase());
-
-  if (conf.typeIsSet()) {
-    setType(conf.getType());
-  }
 }
 
 PortsJsonObject Ports::toJsonObject() {
@@ -54,11 +50,6 @@ PortsTypeEnum Ports::getType() {
   return port_type_;
 }
 
-void Ports::setType(const PortsTypeEnum &value) {
-  // This method set the type value.
-  throw std::runtime_error("Error: Port type cannot be changed at runtime.");
-}
-
 std::shared_ptr<spdlog::logger> Ports::logger() {
   return parent_.logger();
 }

src/services/pcn-k8switch/src/Ports.h

@@ -43,7 +43,6 @@ class Ports : public polycube::service::Port, public PortsInterface {
   /// Type of the LB port (e.g. FRONTEND or BACKEND)
   /// </summary>
   PortsTypeEnum getType() override;
-  void setType(const PortsTypeEnum &value) override;
 
  private:
   K8switch &parent_;

src/services/pcn-k8switch/src/api/K8switchApi.cpp

@@ -1673,30 +1673,6 @@ Response update_k8switch_ports_list_by_id_handler(
   }
 }
 
-Response update_k8switch_ports_type_by_id_handler(
-  const char *name, const Key *keys,
-  size_t num_keys ,
-  const char *value) {
-  // Getting the path params
-  std::string unique_name { name };
-  std::string unique_portsName;
-  for (size_t i = 0; i < num_keys; ++i) {
-    if (!strcmp(keys[i].name, "ports_name")) {
-      unique_portsName = std::string { keys[i].value.string };
-      break;
-    }
-  }
-
-
-  try {
-    auto request_body = nlohmann::json::parse(std::string { value });
-    PortsTypeEnum unique_value_ = PortsJsonObject::string_to_PortsTypeEnum(request_body);
-    update_k8switch_ports_type_by_id(unique_name, unique_portsName, unique_value_);
-    return { kOk, nullptr };
-  } catch(const std::exception &e) {
-    return { kGenericError, ::strdup(e.what()) };
-  }
-}
 
 Response update_k8switch_service_backend_by_id_handler(
   const char *name, const Key *keys,

src/services/pcn-k8switch/src/api/K8switchApi.h

@@ -93,7 +93,6 @@ Response update_k8switch_fwd_table_port_by_id_handler(const char *name, const Ke
 Response update_k8switch_list_by_id_handler(const char *name, const Key *keys, size_t num_keys, const char *value);
 Response update_k8switch_ports_by_id_handler(const char *name, const Key *keys, size_t num_keys, const char *value);
 Response update_k8switch_ports_list_by_id_handler(const char *name, const Key *keys, size_t num_keys, const char *value);
-Response update_k8switch_ports_type_by_id_handler(const char *name, const Key *keys, size_t num_keys, const char *value);
 Response update_k8switch_service_backend_by_id_handler(const char *name, const Key *keys, size_t num_keys, const char *value);
 Response update_k8switch_service_backend_list_by_id_handler(const char *name, const Key *keys, size_t num_keys, const char *value);
 Response update_k8switch_service_backend_name_by_id_handler(const char *name, const Key *keys, size_t num_keys, const char *value);

src/services/pcn-k8switch/src/api/K8switchApiImpl.cpp

@@ -1079,26 +1079,6 @@ update_k8switch_ports_list_by_id(const std::string &name, const std::vector<Port
   throw std::runtime_error("Method not supported");
 }
 
-/**
-* @brief   Update type by ID
-*
-* Update operation of resource: type*
-*
-* @param[in] name ID of name
-* @param[in] portsName ID of ports_name
-* @param[in] value Type of the LB port (e.g. NODEPORT or DEFAULT)
-*
-* Responses:
-*
-*/
-void
-update_k8switch_ports_type_by_id(const std::string &name, const std::string &portsName, const PortsTypeEnum &value) {
-  auto k8switch = get_cube(name);
-  auto ports = k8switch->getPorts(portsName);
-
-  ports->setType(value);
-}
-
 /**
 * @brief   Update backend by ID
 *

src/services/pcn-k8switch/src/api/K8switchApiImpl.h

@@ -97,7 +97,6 @@ namespace K8switchApiImpl {
   void update_k8switch_list_by_id(const std::vector<K8switchJsonObject> &value);
   void update_k8switch_ports_by_id(const std::string &name, const std::string &portsName, const PortsJsonObject &value);
   void update_k8switch_ports_list_by_id(const std::string &name, const std::vector<PortsJsonObject> &value);
-  void update_k8switch_ports_type_by_id(const std::string &name, const std::string &portsName, const PortsTypeEnum &value);
   void update_k8switch_service_backend_by_id(const std::string &name, const std::string &vip, const uint16_t &vport, const ServiceProtoEnum &proto, const std::string &ip, const uint16_t &port, const ServiceBackendJsonObject &value);
   void update_k8switch_service_backend_list_by_id(const std::string &name, const std::string &vip, const uint16_t &vport, const ServiceProtoEnum &proto, const std::vector<ServiceBackendJsonObject> &value);
   void update_k8switch_service_backend_name_by_id(const std::string &name, const std::string &vip, const uint16_t &vport, const ServiceProtoEnum &proto, const std::string &ip, const uint16_t &port, const std::string &value);

src/services/pcn-k8switch/src/interface/PortsInterface.h

@@ -35,6 +35,5 @@ class PortsInterface {
   /// Type of the LB port (e.g. NODEPORT or DEFAULT)
   /// </summary>
   virtual PortsTypeEnum getType() = 0;
-  virtual void setType(const PortsTypeEnum &value) = 0;
 };