pcn-firewall: use default methods in /base when possible

this avoids code duplication and files to become too big

Signed-off-by: Matteo Bertrone <m.bertrone@gmail.com>

Author: mbertrone

src/services/pcn-firewall/src/Chain.cpp

@@ -52,23 +52,6 @@ void Chain::update(const ChainJsonObject &conf) {
   }
 }
 
-ChainJsonObject Chain::toJsonObject() {
-  ChainJsonObject conf;
-
-  conf.setDefault(getDefault());
-
-  for (auto &i : getStatsList()) {
-    conf.addChainStats(i->toJsonObject());
-  }
-
-  conf.setName(getName());
-  for (auto &i : getRuleList()) {
-    conf.addChainRule(i->toJsonObject());
-  }
-
-  return conf;
-}
-
 ActionEnum Chain::getDefault() {
   // This method retrieves the default value.
   return this->defaultAction;
@@ -200,10 +183,6 @@ ChainApplyRulesOutputJsonObject Chain::applyRules() {
   return result;
 }
 
-std::shared_ptr<spdlog::logger> Chain::logger() {
-  return parent_.logger();
-}
-
 uint32_t Chain::getNrRules() {
   return rules_.size();
 }

src/services/pcn-firewall/src/Chain.h

@@ -40,9 +40,7 @@ class Chain : public ChainBase {
   Chain(Firewall &parent, const ChainJsonObject &conf);
   virtual ~Chain();
 
-  std::shared_ptr<spdlog::logger> logger();
   void update(const ChainJsonObject &conf) override;
-  ChainJsonObject toJsonObject() override;
 
   /// <summary>
   /// Default action if no rule matches in the ingress chain. Default is DROP.

src/services/pcn-firewall/src/ChainRule.cpp

@@ -194,7 +194,3 @@ uint32_t ChainRule::getId() {
   // This method retrieves the id value.
   return id;
 }
-
-std::shared_ptr<spdlog::logger> ChainRule::logger() {
-  return parent_.logger();
-}

src/services/pcn-firewall/src/ChainRule.h

@@ -32,7 +32,6 @@ class ChainRule : public ChainRuleBase {
   ChainRule(Chain &parent, const ChainRuleJsonObject &conf);
   virtual ~ChainRule();
 
-  std::shared_ptr<spdlog::logger> logger();
   void update(const ChainRuleJsonObject &conf) override;
   ChainRuleJsonObject toJsonObject() override;
 

src/services/pcn-firewall/src/ChainStats.cpp

@@ -229,7 +229,3 @@ uint16_t ChainStats::getSport() {
 uint32_t ChainStats::getId() {
   return counter.getId();
 }
-
-std::shared_ptr<spdlog::logger> ChainStats::logger() {
-  return parent_.logger();
-}

src/services/pcn-firewall/src/ChainStats.h

@@ -30,7 +30,6 @@ class ChainStats : public ChainStatsBase {
   ChainStats(Chain &parent, const ChainStatsJsonObject &conf);
   virtual ~ChainStats();
 
-  std::shared_ptr<spdlog::logger> logger();
   void update(const ChainStatsJsonObject &conf) override;
   ChainStatsJsonObject toJsonObject() override;