Generalize OS detection. (#232)

trombonehero · web-flow · commit 043a3a73bdbf · 2024-09-05T18:12:38.000+02:00
There are many Unix-like OSes that have xdg-open that are not Linux.
Rather than enumerating DragonflyBSD, FreeBSD, NetBSD, OpenBSD, etc.,
change this "Linux" target to "Unix and not Android and not MacOS".
diff --git a/plotly/src/plot.rs b/plotly/src/plot.rs
@@ -464,7 +464,7 @@ impl Plot {
             .expect("Invalid JSON structure - expected a top-level Object")
     }
 
-    #[cfg(target_os = "linux")]
+    #[cfg(all(unix, not(target_os = "android"), not(target_os = "macos")))]
     fn show_with_default_app(temp_path: &str) {
         use std::process::Command;
         Command::new("xdg-open")

Original file line number	Diff line number	Diff line change
`@@ -464,7 +464,7 @@ impl Plot {`
`464`	`464`	`.expect("Invalid JSON structure - expected a top-level Object")`
`465`	`465`	`}`
`466`	`466`
`467`		`- #[cfg(target_os = "linux")]`
	`467`	`+ #[cfg(all(unix, not(target_os = "android"), not(target_os = "macos")))]`
`468`	`468`	`fn show_with_default_app(temp_path: &str) {`
`469`	`469`	`use std::process::Command;`
`470`	`470`	`Command::new("xdg-open")`