Skip to content

Commit d838891

Browse files
committed
Add dash attribute support to marker lines across scatter trace types
- Extends marker line styling capabilities by including the `dash` attribute alongside existing `width` attribute - Enables dashed marker line borders for `scatter3d`, `scattercarpet`, `scattergeo`, `scattergl`, `scatterternary`, and `splom` trace types - Maintains consistency with base scatter trace marker line attributes by reusing `scatterMarkerLineAttrs.dash` - Applies appropriate constraints where needed, such as `arrayOk: false` for 3D traces and `editType: 'calc'` for other trace types
1 parent 8c1fdf2 commit d838891

6 files changed

Lines changed: 9 additions & 3 deletions

File tree

src/traces/scatter3d/attributes.js

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -150,7 +150,8 @@ var attrs = (module.exports = overrideAll(
150150

151151
line: extendFlat(
152152
{
153-
width: extendFlat({}, scatterMarkerLineAttrs.width, { arrayOk: false })
153+
width: extendFlat({}, scatterMarkerLineAttrs.width, { arrayOk: false }),
154+
dash: extendFlat({}, scatterMarkerLineAttrs.dash, { arrayOk: false })
154155
},
155156
colorAttributes('marker.line')
156157
)

src/traces/scattercarpet/attributes.js

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -97,6 +97,7 @@ module.exports = {
9797
line: extendFlat(
9898
{
9999
width: scatterMarkerLineAttrs.width,
100+
dash: scatterMarkerLineAttrs.dash,
100101
editType: 'calc'
101102
},
102103
colorScaleAttrs('marker.line')

src/traces/scattergeo/attributes.js

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -139,7 +139,8 @@ module.exports = overrideAll(
139139
colorbar: scatterMarkerAttrs.colorbar,
140140
line: extendFlat(
141141
{
142-
width: scatterMarkerLineAttrs.width
142+
width: scatterMarkerLineAttrs.width,
143+
dash: scatterMarkerLineAttrs.dash
143144
},
144145
colorAttributes('marker.line')
145146
),

src/traces/scattergl/attributes.js

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -83,7 +83,8 @@ var attrs = (module.exports = overrideAll(
8383
opacity: scatterMarkerAttrs.opacity,
8484
colorbar: scatterMarkerAttrs.colorbar,
8585
line: extendFlat({}, colorScaleAttrs('marker.line'), {
86-
width: scatterMarkerLineAttrs.width
86+
width: scatterMarkerLineAttrs.width,
87+
dash: scatterMarkerLineAttrs.dash
8788
})
8889
}),
8990
connectgaps: scatterAttrs.connectgaps,

src/traces/scatterternary/attributes.js

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -126,6 +126,7 @@ module.exports = {
126126
line: extendFlat(
127127
{
128128
width: scatterMarkerLineAttrs.width,
129+
dash: scatterMarkerLineAttrs.dash,
129130
editType: 'calc'
130131
},
131132
colorScaleAttrs('marker.line')

src/traces/splom/attributes.js

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -14,6 +14,7 @@ var scatterMarkerLineAttrs = scatterMarkerAttrs.line;
1414

1515
var markerLineAttrs = extendFlat(colorScaleAttrs('marker.line', { editTypeOverride: 'calc' }), {
1616
width: extendFlat({}, scatterMarkerLineAttrs.width, { editType: 'calc' }),
17+
dash: extendFlat({}, scatterMarkerLineAttrs.dash, { editType: 'calc' }),
1718
editType: 'calc'
1819
});
1920

0 commit comments

Comments
 (0)