Skip to content

Commit ebc480e

Browse files
committed
Fix CI tests
1 parent 2cfaafb commit ebc480e

5 files changed

Lines changed: 22 additions & 17 deletions

File tree

components/dash-core-components/src/utils/optionRendering.tsx

Lines changed: 5 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -345,11 +345,6 @@ export const OptionsList = forwardRef<OptionsListHandle, OptionsListProps>(
345345
style={style}
346346
role="listbox"
347347
>
348-
{sizerDiv && (
349-
<div aria-hidden style={{height: 0, overflow: 'hidden'}}>
350-
{sizerDiv}
351-
</div>
352-
)}
353348
<VariableSizeList
354349
ref={listRef}
355350
height={listHeight}
@@ -363,6 +358,11 @@ export const OptionsList = forwardRef<OptionsListHandle, OptionsListProps>(
363358
>
364359
{Row}
365360
</VariableSizeList>
361+
{sizerDiv && (
362+
<div aria-hidden style={{height: 0, overflow: 'hidden'}}>
363+
{sizerDiv}
364+
</div>
365+
)}
366366
</div>
367367
);
368368
}

components/dash-core-components/tests/integration/dropdown/test_a11y.py

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -389,6 +389,7 @@ def get_focused_option_text():
389389

390390
# Now arrow down to first option
391391
send_keys(Keys.ARROW_DOWN)
392+
sleep(0.1)
392393
assert get_focused_option_text() == "Option 0"
393394

394395
# Test End key - should go to last option

components/dash-core-components/tests/integration/misc/test_persistence.py

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -121,7 +121,7 @@ def make_output(*args):
121121
dash_dcc.driver.set_window_size(1024, 768)
122122
dash_dcc.wait_for_text_to_equal("#settings", json.dumps(initial_settings))
123123

124-
dash_dcc.find_element("#checklist label:last-child input").click() # 🚀
124+
dash_dcc.find_element('#checklist [data-option-index="2"] input').click() # 🚀
125125

126126
dash_dcc.select_date_range("datepickerrange", day_range=(4,))
127127
dash_dcc.select_date_range("datepickerrange", day_range=(14,), start_first=False)
@@ -145,7 +145,7 @@ def make_output(*args):
145145

146146
dash_dcc.find_element("#input").send_keys(" maybe")
147147

148-
dash_dcc.find_element("#radioitems label:first-child input").click() # red
148+
dash_dcc.find_element('#radioitems [data-option-index="0"] input').click() # red
149149

150150
range_slider = dash_dcc.find_element("#rangeslider")
151151
dash_dcc.click_at_coord_fractions(range_slider, 0.5, 0.25) # 5

tests/integration/renderer/test_children_reorder.py

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -63,12 +63,12 @@ def swap_button_action(n_clicks, children):
6363
for i in range(2):
6464
dash_duo.wait_for_text_to_equal("h1", f"I am section {i}")
6565
dash_duo.find_element(f".dropdown_{i}").click()
66-
dash_duo.find_element(".dash-dropdown-option:nth-child(1)").click()
66+
dash_duo.find_element('.dash-dropdown-option[data-option-index="0"]').click()
6767
dash_duo.wait_for_text_to_equal(f".dropdown_{i} .dash-dropdown-trigger", "A")
68-
dash_duo.find_element(".dash-dropdown-option:nth-child(2)").click()
68+
dash_duo.find_element('.dash-dropdown-option[data-option-index="1"]').click()
6969
value_items = dash_duo.find_elements(f".dropdown_{i} .dash-dropdown-value-item")
7070
assert [item.text for item in value_items] == ["A", "B"]
71-
dash_duo.find_element(".dash-dropdown-option:nth-child(3)").click()
71+
dash_duo.find_element('.dash-dropdown-option[data-option-index="2"]').click()
7272
value_items = dash_duo.find_elements(f".dropdown_{i} .dash-dropdown-value-item")
7373
assert [item.text for item in value_items] == ["A", "B", "C"]
7474

tests/integration/renderer/test_component_as_prop.py

Lines changed: 11 additions & 7 deletions
Original file line numberDiff line numberDiff line change
@@ -357,13 +357,13 @@ def demo(n_clicks):
357357
dash_duo.start_server(app)
358358

359359
dash_duo.wait_for_element("#add-option").click()
360-
for i in range(1, n + 2):
360+
for i in range(n + 1):
361361
dash_duo.wait_for_text_to_equal(
362-
f"#options label:nth-child({i}) span.label-result", ""
362+
f'#options [data-option-index="{i}"] span.label-result', ""
363363
)
364-
dash_duo.wait_for_element(f"#options label:nth-child({i}) button").click()
364+
dash_duo.wait_for_element(f'#options [data-option-index="{i}"] button').click()
365365
dash_duo.wait_for_text_to_equal(
366-
f"#options label:nth-child({i}) span.label-result", "1"
366+
f'#options [data-option-index="{i}"] span.label-result', "1"
367367
)
368368

369369

@@ -393,13 +393,17 @@ def opts(n):
393393

394394
dash_duo.wait_for_text_to_equal("#counter", "0")
395395
dash_duo.find_element("#a").click()
396-
assert len(dash_duo.find_elements("#b label input")) == 2
396+
assert (
397+
len(dash_duo.find_elements('#b label:not([data-option-index="-1"]) input')) == 2
398+
)
397399
dash_duo.wait_for_text_to_equal("#counter", "0")
398400
dash_duo.find_element("#a").click()
399-
assert len(dash_duo.find_elements("#b label input")) == 3
401+
assert (
402+
len(dash_duo.find_elements('#b label:not([data-option-index="-1"]) input')) == 3
403+
)
400404
dash_duo.wait_for_text_to_equal("#counter", "0")
401405

402-
dash_duo.find_elements("#b label input")[0].click()
406+
dash_duo.find_elements('#b label:not([data-option-index="-1"]) input')[0].click()
403407
dash_duo.wait_for_text_to_equal("#counter", "1")
404408

405409

0 commit comments

Comments
 (0)