Skip to content

Commit ec0c526

Browse files
committed
add missing dimensions parsing
1 parent 6aec597 commit ec0c526

2 files changed

Lines changed: 4 additions & 2 deletions

File tree

lib/plausible/stats/api_query_parser.ex

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -221,14 +221,14 @@ defmodule Plausible.Stats.ApiQueryParser do
221221
end
222222
end
223223

224-
defp parse_dimensions(dimensions) when is_list(dimensions) do
224+
def parse_dimensions(dimensions) when is_list(dimensions) do
225225
parse_list(
226226
dimensions,
227227
&parse_dimension_entry(&1, "Invalid dimensions '#{i(dimensions)}'")
228228
)
229229
end
230230

231-
defp parse_dimensions(nil), do: {:ok, []}
231+
def parse_dimensions(nil), do: {:ok, []}
232232

233233
def parse_order_by(order_by) when is_list(order_by) do
234234
parse_list(order_by, &parse_order_by_entry/1)

lib/plausible/stats/dashboard/query_parser.ex

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -17,13 +17,15 @@ defmodule Plausible.Stats.Dashboard.QueryParser do
1717
def parse(params) do
1818
with {:ok, input_date_range} <- parse_input_date_range(params),
1919
{:ok, relative_date} <- parse_relative_date(params),
20+
{:ok, dimensions} <- ApiQueryParser.parse_dimensions(params["dimensions"]),
2021
{:ok, filters} <- ApiQueryParser.parse_filters(params["filters"]),
2122
{:ok, metrics} <- parse_metrics(params),
2223
{:ok, include} <- parse_include(params) do
2324
{:ok,
2425
ParsedQueryParams.new!(%{
2526
input_date_range: input_date_range,
2627
relative_date: relative_date,
28+
dimensions: dimensions,
2729
filters: filters,
2830
metrics: metrics,
2931
include: include,

0 commit comments

Comments
 (0)