Skip to content

Commit 448f3e4

Browse files
committed
fix CI (ce_test, codespell, credo)
1 parent 591e538 commit 448f3e4

3 files changed

Lines changed: 7 additions & 5 deletions

File tree

.codespellignore

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -7,3 +7,4 @@ referer
77
referers
88
statics
99
firs
10+
IST

lib/plausible_web/controllers/api/external_stats_controller.ex

Lines changed: 5 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -76,9 +76,10 @@ defmodule PlausibleWeb.Api.ExternalStatsController do
7676

7777
@max_breakdown_limit 1000
7878
defp validate_or_default_limit(%{"limit" => limit}) do
79-
with {limit, ""} when limit > 0 and limit <= @max_breakdown_limit <- Integer.parse(limit) do
80-
{:ok, limit}
81-
else
79+
case Integer.parse(limit) do
80+
{limit, ""} when limit > 0 and limit <= @max_breakdown_limit ->
81+
{:ok, limit}
82+
8283
_ ->
8384
{:error, "Please provide limit as a number between 1 and #{@max_breakdown_limit}."}
8485
end
@@ -313,7 +314,7 @@ defmodule PlausibleWeb.Api.ExternalStatsController do
313314
defp validate_period(_), do: :ok
314315

315316
@valid_intervals ["day", "month"]
316-
@valid_intervals_str Enum.map(@valid_intervals, &("`" <> &1 <> "`")) |> Enum.join(", ")
317+
@valid_intervals_str Enum.map_join(@valid_intervals, ", ", &("`" <> &1 <> "`"))
317318

318319
defp validate_interval(%{"interval" => interval}) do
319320
if interval in @valid_intervals do

test/plausible/stats/query/query_test.exs

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -590,7 +590,7 @@ defmodule Plausible.Stats.QueryTest do
590590
test "is ignored when event:goal dimension used", %{site: site} do
591591
{:ok, query} =
592592
QueryBuilder.build(site, %ParsedQueryParams{
593-
metrics: [:visitors, :average_revenue],
593+
metrics: [:visitors],
594594
input_date_range: :all,
595595
include: %QueryInclude{empty_metrics: true},
596596
dimensions: ["event:goal"]

0 commit comments

Comments
 (0)