Skip to content

Commit 12b7f44

Browse files
committed
Unify BE and FE change calculations
1 parent fcbda79 commit 12b7f44

1 file changed

Lines changed: 7 additions & 7 deletions

File tree

assets/js/dashboard/stats/graph/main-graph-data.ts

Lines changed: 7 additions & 7 deletions
Original file line numberDiff line numberDiff line change
@@ -5,16 +5,16 @@ import { MainGraphResponse } from './fetch-main-graph'
55
* Fills gaps in @see MainGraphResponse the series of `results` and `comparisonResults`.
66
* The BE doesn't return buckets in the series where the value is 0:
77
* these need to filled by the FE to have a consistent plot.
8-
*
8+
*
99
* The assumption is that the two series each are continuously defined.
10-
*
10+
*
1111
* Extracts the numeric values for the series when they are wrapped.
12-
*
13-
* In the same single loop, for the sake of efficiency, it determines
12+
*
13+
* In the same single loop, for the sake of efficiency, it determines
1414
* - the maximum y value (used for scaling the graph),
1515
* - the start and end labels of both series (used for generating appropriate X axis labels),
1616
* - whether there's a slice at the very end of main series that is partial (used for explaining the drop at the end of the graph).
17-
*
17+
*
1818
*/
1919
export const remapAndFillData = ({
2020
data,
@@ -173,8 +173,8 @@ export const remapAndFillData = ({
173173
const METRICS_WITH_CHANGE_IN_PERCENTAGE_POINTS = [
174174
'bounce_rate',
175175
'exit_rate',
176-
'conversion_rate',
177-
'group_conversion_rate'
176+
'conversion_rate'
177+
// 'group_conversion_rate'
178178
]
179179

180180
const getChangeInPercentagePoints = (

0 commit comments

Comments
 (0)