Merge pull request #49 from phrase/ruby-3.0-support

Ruby 3.0 support

Author: sbruhns

.github/workflows/test.yml

@@ -5,7 +5,7 @@ jobs:
     strategy:
       fail-fast: false
       matrix:
-        ruby: [2.2, 2.3, 2.4, 2.5, 2.6, 2.7]
+        ruby: [2.2, 2.3, 2.4, 2.5, 2.6, 2.7, 3.0]
     runs-on: ubuntu-latest
     steps:
     - uses: actions/checkout@v2

.tool-versions

@@ -0,0 +1 @@
+ruby 3.0.0

lib/phraseapp-in-context-editor-ruby/backend_service.rb

@@ -14,7 +14,27 @@ def initialize(args = {})
 
       def translate(*args)
         if to_be_translated_without_phraseapp?(args)
-          I18n.translate_without_phraseapp(*args)
+          # *Ruby 2.7+ keyword arguments warning*
+          #
+          # This method uses keyword arguments.
+          # There is a breaking change in ruby that produces warning with ruby 2.7 and won't work as expected with ruby 3.0
+          # The "hash" parameter must be passed as keyword argument.
+          #
+          # Good:
+          #  I18n.t(:salutation, :gender => 'w', :name => 'Smith')
+          #  I18n.t(:salutation, **{ :gender => 'w', :name => 'Smith' })
+          #  I18n.t(:salutation, **any_hash)
+          #
+          # Bad:
+          #  I18n.t(:salutation, { :gender => 'w', :name => 'Smith' })
+          #  I18n.t(:salutation, any_hash)
+          #
+          kw_args = args[1]
+          if kw_args.present?
+            I18n.translate_without_phraseapp(args[0], **kw_args)
+          else
+            I18n.translate_without_phraseapp(args[0])
+          end
         else
           phraseapp_delegate_for(args)
         end

spec/phraseapp-in-context-editor-ruby/backend_service_spec.rb

@@ -134,6 +134,13 @@
 
           it { is_expected.to eql "translation missing: en.context.key" }
         end
+
+        context "scope array given in rails 3 style" do
+          let(:context_key_translation) { double }
+          let(:args) { [:key, **{ :scope => [:context] }] }
+
+          it { is_expected.to eql "translation missing: en.context.key" }
+        end
       end
     end
   end