Add preview tests

Author: iMattPro

tests/controller/post_controller_test.php

@@ -95,11 +95,11 @@ public function test_controller_exception($forum, $user_id, $status_code, $page_
 	}
 
 	/**
-	 * Test data for the test_submit_success test
+	 * Test data for the test_post_success test
 	 *
 	 * @return array Array of test data
 	 */
-	public function submit_success_data()
+	public function post_success_data()
 	{
 		return array(
 			array(true),
@@ -108,27 +108,27 @@ public function submit_success_data()
 	}
 
 	/**
-	 * Test submit
+	 * Test post
 	 *
-	 * @dataProvider submit_success_data
+	 * @dataProvider post_success_data
 	 */
-	public function test_submit_success($is_newly_registered_user)
+	public function test_post_success($is_newly_registered_user)
 	{
 		/** @var \phpbb\ideas\controller\post_controller $controller */
 		$controller = $this->get_controller('post_controller');
 		$this->assertInstanceOf('phpbb\ideas\controller\post_controller', $controller);
 
-		$this->controller_helper->expects($this->any())
+		$this->controller_helper->expects($this->once())
 			->method('route')
 			->will($this->returnValue('phpbb_ideas_idea_controller'));
 
-		$this->request->expects($this->any())
-			->method('variable')
+		$this->request->expects($this->once())
+			->method('is_set_post')
 			->will($this->returnValueMap(array(
-				array('mode', '', false, \phpbb\request\request_interface::REQUEST, 'submit'),
+				array('post', true),
 			)));
 
-		$this->auth->expects($this->any())
+		$this->auth->expects($this->once())
 			->method('acl_get')
 			->with('f_noapprove', $this->config['ideas_forum_id'])
 			->will($this->returnValue(!$is_newly_registered_user));
@@ -139,14 +139,55 @@ public function test_submit_success($is_newly_registered_user)
 		}
 
 		// ideas->submit() will return an idea id on successful submit
-		$this->ideas->expects($this->any())
+		$this->ideas->expects($this->once())
 			->method('submit')
 			->will($this->returnValue(1));
 
 		$response = $controller->post();
 		$this->assertInstanceOf('\Symfony\Component\HttpFoundation\RedirectResponse', $response);
 	}
 
+	/**
+	 * Test preview
+	 */
+	public function test_preview()
+	{
+		/** @var \phpbb\ideas\controller\post_controller $controller */
+		$controller = $this->get_controller('post_controller');
+		$this->assertInstanceOf('phpbb\ideas\controller\post_controller', $controller);
+
+		$this->request->expects($this->any())
+			->method('is_set_post')
+			->will($this->returnValueMap(array(
+				array('post', false),
+				array('preview', true),
+			)));
+
+		$this->request->expects($this->atLeastOnce())
+			->method('variable')
+			->will($this->returnValueMap(array(
+				array('title', '', true, \phpbb\request\request_interface::REQUEST, 'test title'),
+				array('message', '', true, \phpbb\request\request_interface::REQUEST, 'test message'),
+			)));
+
+		$this->ideas->expects($this->never())
+			->method('submit');
+
+		$this->ideas->expects($this->once())
+			->method('preview')
+			->willReturn('test message');
+
+		$this->template->expects($this->at(0))
+			->method('assign_vars')
+			->with(array(
+				'S_DISPLAY_PREVIEW' => true,
+				'PREVIEW_SUBJECT'   => 'test title',
+				'PREVIEW_MESSAGE'   => 'test message'
+			));
+
+		$controller->post();
+	}
+
 	/**
 	 * Test submit errors
 	 */
@@ -156,16 +197,22 @@ public function test_submit_errors()
 		$controller = $this->get_controller('post_controller');
 		$this->assertInstanceOf('phpbb\ideas\controller\post_controller', $controller);
 
-		$this->request->expects($this->any())
+		$this->request->expects($this->atLeastOnce())
+			->method('is_set_post')
+			->will($this->returnValueMap(array(
+				array('post', true),
+				array('preview', false),
+			)));
+
+		$this->request->expects($this->atLeastOnce())
 			->method('variable')
 			->will($this->returnValueMap(array(
-				array('mode', '', false, \phpbb\request\request_interface::REQUEST, 'submit'),
 				array('title', '', true, \phpbb\request\request_interface::REQUEST, 'test title'),
 				array('message', '', true, \phpbb\request\request_interface::REQUEST, 'test message'),
 			)));
 
 		// ideas->submit() will return an array of error messages on submit error
-		$this->ideas->expects($this->any())
+		$this->ideas->expects($this->once())
 			->method('submit')
 			->will($this->returnValue(array('error1', 'error2')));
 

tests/ideas/preview_idea_test.php

@@ -0,0 +1,65 @@
+<?php
+/**
+ *
+ * Ideas extension for the phpBB Forum Software package.
+ *
+ * @copyright (c) phpBB Limited <https://www.phpbb.com>
+ * @license GNU General Public License, version 2 (GPL-2.0)
+ *
+ */
+
+namespace phpbb\ideas\factory;
+
+class preview_idea_test extends \phpbb\ideas\tests\ideas\ideas_base
+{
+	public function setUp()
+	{
+		parent::setUp();
+
+		global $phpbb_container;
+
+		// This is needed to set up the s9e text formatter services
+		// This can lead to a test failure if PCRE is old.
+		$this->get_test_case_helpers()->set_s9e_services($phpbb_container);
+	}
+
+	/**
+	 * Test preview() data
+	 *
+	 * @return array
+	 */
+	public function preview_test_data()
+	{
+		return array(
+			array('New idea 1 posted by the test framework.'),
+			array('New idea 2 [u]posted[/u] by the test [b]framework[/b].'),
+		);
+	}
+
+	/**
+	 * Test preview()
+	 *
+	 * @dataProvider preview_test_data
+	 */
+	public function test_preview($message)
+	{
+		// Get the ideas object
+		$ideas = $this->get_ideas_object();
+
+		// store the message in a temp variable, since it will forever altered
+		$test_message = $message;
+
+		// Prepare the test message for storage
+		$uid = $bitfield = $flags = '';
+		generate_text_for_storage($test_message, $uid, $bitfield, $flags, true, true, true);
+
+		// Prepare the test message for display
+		$expected = generate_text_for_display($test_message, $uid, $bitfield, $flags);
+
+		// Actually run the original test message through preview method
+		$preview = $ideas->preview($message);
+
+		// Assert preview message was parsed and rendered as expected
+		$this->assertEquals($expected, $preview);
+	}
+}