Remove the old clean message event listener

Author: iMattPro

event/listener.php

@@ -82,7 +82,7 @@ public static function getSubscribedEvents()
 	{
 		return array(
 			'core.viewforum_get_topic_data'				=> 'ideas_forum_redirect',
-			'core.viewtopic_modify_post_row'			=> array(array('clean_message'), array('show_post_buttons')),
+			'core.viewtopic_modify_post_row'			=> 'show_post_buttons',
 			'core.viewtopic_modify_page_title'			=> 'show_idea',
 			'core.viewtopic_add_quickmod_option_before'	=> 'adjust_quickmod_tools',
 			'core.viewonline_overwrite_location'		=> 'viewonline_ideas',
@@ -107,31 +107,6 @@ public function ideas_forum_redirect($event)
 		}
 	}
 
-	/**
-	 * Clean obsolete link-backs from idea topics posted prior to Sep. 2017
-	 *
-	 * @param \phpbb\event\data $event The event object
-	 * @return void
-	 * @access public
-	 */
-	public function clean_message($event)
-	{
-		if (!$this->is_ideas_forum($event['row']['forum_id']))
-		{
-			return;
-		}
-
-		if ($this->is_first_post($event['topic_data']['topic_first_post_id'], $event['row']['post_id']) && $event['topic_data']['topic_time'] < strtotime('September 1, 2017'))
-		{
-			// This freakish looking regex pattern should remove the old ideas link-backs from the message.
-			$event->update_subarray(
-				'post_row',
-				'MESSAGE',
-				preg_replace('/(<br[^>]*>\\n?)?\\1?-{10}\\1?\\1?(?:(?!<\/[rt]>).)*/s', '', $event['post_row']['MESSAGE'])
-			);
-		}
-	}
-
 	/**
 	 * Show post buttons (hide delete, quote or warn user buttons)
 	 *

tests/event/listener_test.php

@@ -118,46 +118,6 @@ public function test_getSubscribedEvents()
 		), array_keys(\phpbb\ideas\event\listener::getSubscribedEvents()));
 	}
 
-	/**
-	 * Data set for test_clean_message
-	 *
-	 * @return array Array of test data
-	 */
-	public function clean_message_data()
-	{
-		return array(
-			array(1, 1, 1, 'Foo Bar', 'Foo Bar'), // Invalid forum, nothing cleaned
-			array(2, 1, 2, 'Foo Bar', 'Foo Bar'), // Invalid post, nothing clean
-			array(2, 1, 1, 'Foo Bar', 'Foo Bar'), // Valid post, nothing to clean
-			array(2, 1, 1, 'Foo Bar<br />----------<br>BarFoo<br>', 'Foo Bar'), // Valid post, requires cleaning
-			array(2, 1, 1, 'Foo Bar<br />\n\n----------<br>\nBarFoo<br>', 'Foo Bar'), // Valid post, requires cleaning
-			array(2, 1, 1, 'Foo Bar<br />--------<br>BarFoo<br>', 'Foo Bar<br />--------<br>BarFoo<br>'), // Valid post, nothing to clean
-		);
-	}
-
-	/**
-	 * Test the clean_message event
-	 *
-	 * @dataProvider clean_message_data
-	 */
-	public function test_clean_message($forum_id, $post_id, $first_post_id, $message, $expected)
-	{
-		$listener = $this->get_listener();
-
-		$event = new \phpbb\event\data(array(
-			'row' 			=> array(
-				'forum_id'	=> $forum_id,
-				'post_id'	=> $post_id,
-			),
-			'post_row'		=> array('MESSAGE' => $message),
-			'topic_data'	=> array('topic_first_post_id' => $first_post_id),
-		));
-
-		$listener->clean_message($event);
-
-		$this->assertContains($expected, $event['post_row']['MESSAGE']);
-	}
-
 	/**
 	 * Data set for show_post_buttons
 	 *