Update testing

Signed-off-by: Matt Friedman <maf675@gmail.com>

Author: iMattPro

.github/workflows/tests.yml

@@ -25,7 +25,7 @@ jobs:
         strategy:
             matrix:
                 include:
-                    - php: '7.1'
+                    - php: '7.2'
                       db: "none"
                       NOTESTS: 1
 
@@ -123,6 +123,8 @@ jobs:
                       db: "mysql:5.7"
                     - php: '8.1'
                       db: "mysql:5.7"
+                    - php: '8.2'
+                      db: "mysql:5.7"
 
         name: PHP ${{ matrix.php }} - ${{ matrix.db_alias != '' && matrix.db_alias || matrix.db }}
 
@@ -221,6 +223,20 @@ jobs:
                       db: "postgres:12"
                     - php: '7.1'
                       db: "postgres:13"
+                    - php: '7.2'
+                      db: "postgres:13"
+                    - php: '7.3'
+                      db: "postgres:13"
+                    - php: '7.4'
+                      db: "postgres:13"
+                    - php: '8.0'
+                      db: "postgres:12"
+                    - php: '8.0'
+                      db: "postgres:13"
+                    - php: '8.1'
+                      db: "postgres:14"
+                    - php: '8.2'
+                      db: "postgres:14"
 
         name: PHP ${{ matrix.php }} - ${{ matrix.db }}
 

tests/cron/cron_test.php

@@ -0,0 +1,84 @@
+<?php
+/**
+ *
+ * Ideas extension for the phpBB Forum Software package.
+ *
+ * @copyright (c) phpBB Limited <https://www.phpbb.com>
+ * @license GNU General Public License, version 2 (GPL-2.0)
+ *
+ */
+
+namespace phpbb\ideas\tests\cron;
+
+class cron_test extends \phpbb_test_case
+{
+	/** @var \phpbb\config\config */
+	protected $config;
+
+	/** @var \phpbb\ideas\cron\prune_orphaned_ideas */
+	protected $cron_task;
+
+	/** @var \phpbb\ideas\factory\ideas|\PHPUnit\Framework\MockObject\MockObject */
+	protected $ideas;
+
+	protected function setUp(): void
+	{
+		parent::setUp();
+
+		$this->config = new \phpbb\config\config(['ideas_cron_last_run' => 0]);
+
+		$this->ideas = $this->getMockBuilder('\phpbb\ideas\factory\ideas')
+			->disableOriginalConstructor()
+			->getMock();
+
+		$this->cron_task = new \phpbb\ideas\cron\prune_orphaned_ideas($this->config, $this->ideas);
+	}
+
+	/**
+	 * Test the cron task runs correctly
+	 */
+	public function test_run()
+	{
+		// Get last run time stored for cron
+		$cron_last_run = $this->config['ideas_cron_last_run'];
+
+		// Expect ideas method delete_orphans is called once
+		$this->ideas->expects(self::once())
+			->method('delete_orphans');
+
+		// Run the cron task
+		$this->cron_task->run();
+
+		// Now the last run time should be greater than before the test
+		self::assertGreaterThan($cron_last_run, $this->config['ideas_cron_last_run']);
+	}
+
+	/**
+	 * Data set for test_should_run
+	 *
+	 * @return array Array of test data
+	 */
+	public function should_run_data()
+	{
+		return array(
+			array(time(), false),
+			array(strtotime('1 day ago'), false),
+			array(strtotime('8 days ago'), true),
+			array('', true),
+			array(0, true),
+			array(null, true),
+		);
+	}
+
+	/**
+	 * Test cron task should run after 1 week (7 days)
+	 *
+	 * @dataProvider should_run_data
+	 */
+	public function test_should_run($time, $expected)
+	{
+		$this->config['ideas_cron_last_run'] = $time;
+
+		self::assertSame($expected, $this->cron_task->should_run());
+	}
+}