Small updates

iMattPro · iMattPro · commit ca72f14dff2f · 2020-05-19T16:47:34.000-07:00
diff --git a/controller/livesearch_controller.php b/controller/livesearch_controller.php
@@ -22,9 +22,9 @@ public function title_search()
 		$matches = $this->ideas->ideas_title_livesearch($title_chars, 10);
 
 		$json_response = new \phpbb\json_response();
-		$json_response->send(array(
+		$json_response->send([
 			'keyword' => $title_chars,
 			'results' => $matches,
-		));
+		]);
 	}
 }
diff --git a/factory/ideas.php b/factory/ideas.php
@@ -285,7 +285,7 @@ public function ideas_title_livesearch($search, $limit = 10)
 				'idea_id'     => $row['idea_id'],
 				'result'      => $row['idea_id'],
 				'clean_title' => $row['idea_title'],
-				'display'     => "<span>{$row['idea_title']}</span>",
+				'display'     => "<span>{$row['idea_title']}</span>", // spans are expected in phpBB's live search JS
 			];
 		}
 		$this->db->sql_freeresult($result);

Original file line number	Diff line number	Diff line change
`@@ -22,9 +22,9 @@ public function title_search()`
`22`	`22`	`$matches = $this->ideas->ideas_title_livesearch($title_chars, 10);`
`23`	`23`
`24`	`24`	`$json_response = new \phpbb\json_response();`
`25`		`- $json_response->send(array(`
	`25`	`+ $json_response->send([`
`26`	`26`	`'keyword' => $title_chars,`
`27`	`27`	`'results' => $matches,`
`28`		`- ));`
	`28`	`+ ]);`
`29`	`29`	`}`
`30`	`30`	`}`
Original file line number	Diff line number	Diff line change
`@@ -285,7 +285,7 @@ public function ideas_title_livesearch($search, $limit = 10)`
`285`	`285`	`'idea_id' => $row['idea_id'],`
`286`	`286`	`'result' => $row['idea_id'],`
`287`	`287`	`'clean_title' => $row['idea_title'],`
`288`		`- 'display' => "<span>{$row['idea_title']}</span>",`
	`288`	`+ 'display' => "<span>{$row['idea_title']}</span>", // spans are expected in phpBB's live search JS`
`289`	`289`	`];`
`290`	`290`	`}`
`291`	`291`	`$this->db->sql_freeresult($result);`