Skip to content

Commit b77ab39

Browse files
committed
Update tests
1 parent 2befaba commit b77ab39

3 files changed

Lines changed: 24 additions & 0 deletions

File tree

tests/controller/idea_controller_test.php

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -40,6 +40,8 @@ public function controller_test_data()
4040
array(8, 'title', 'set_title', true, false, 'false', 200), // ajax set title fail
4141
array(9, 'vote', 'vote', true, true, 'true', 200), // ajax set title success
4242
array(9, 'vote', 'vote', true, false, '"You do not have the necessary permissions to complete this operation."', 200), // ajax set title fail
43+
array(10, 'implemented', 'set_implemented', true, true, 'true', 200), // ajax set implemented success
44+
array(10, 'implemented', 'set_implemented', true, false, 'false', 200), // ajax set implemented fail
4345
);
4446
}
4547

tests/fixtures/ideas.xml

Lines changed: 7 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -12,6 +12,7 @@
1212
<column>ticket_id</column>
1313
<column>duplicate_id</column>
1414
<column>rfc_link</column>
15+
<column>implemented_version</column>
1516
<row>
1617
<value>1</value>
1718
<value>2</value>
@@ -24,6 +25,7 @@
2425
<value>1234</value>
2526
<value>0</value>
2627
<value></value>
28+
<value></value>
2729
</row>
2830
<row>
2931
<value>2</value>
@@ -37,6 +39,7 @@
3739
<value>0</value>
3840
<value>0</value>
3941
<value></value>
42+
<value></value>
4043
</row>
4144
<row>
4245
<value>3</value>
@@ -50,6 +53,7 @@
5053
<value>0</value>
5154
<value>0</value>
5255
<value></value>
56+
<value></value>
5357
</row>
5458
<row>
5559
<value>4</value>
@@ -63,6 +67,7 @@
6367
<value>0</value>
6468
<value>0</value>
6569
<value></value>
70+
<value></value>
6671
</row>
6772
<row>
6873
<value>5</value>
@@ -76,6 +81,7 @@
7681
<value>0</value>
7782
<value>0</value>
7883
<value></value>
84+
<value></value>
7985
</row>
8086
<row>
8187
<value>6</value>
@@ -89,6 +95,7 @@
8995
<value>0</value>
9096
<value>0</value>
9197
<value></value>
98+
<value></value>
9299
</row>
93100
</table>
94101
<table name="phpbb_ideas_votes">

tests/ideas/idea_attributes_test.php

Lines changed: 15 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -86,6 +86,7 @@ public function idea_attribute_test_data()
8686
'idea_id' => 1,
8787
'duplicate_id' => 2,
8888
'rfc_link' => 'http://area51.phpbb.com/phpBB/viewtopic.php?foo&bar',
89+
'implemented_version' => '3.1.0',
8990
'ticket_id' => 1111,
9091
'idea_title' => 'Foo Idea 1',
9192
), true
@@ -95,6 +96,7 @@ public function idea_attribute_test_data()
9596
'idea_id' => 2,
9697
'duplicate_id' => 1,
9798
'rfc_link' => 'https://area51.phpbb.com/phpBB/viewtopic.php?bar&foo',
99+
'implemented_version' => '3.2.0',
98100
'ticket_id' => 2222,
99101
'idea_title' => 'Foo Idea 2',
100102
), true
@@ -104,6 +106,7 @@ public function idea_attribute_test_data()
104106
'idea_id' => 3,
105107
'duplicate_id' => '5',
106108
'rfc_link' => '',
109+
'implemented_version' => '',
107110
'ticket_id' => '3333',
108111
'idea_title' => 'Føó Îdéå',
109112
), true
@@ -113,6 +116,7 @@ public function idea_attribute_test_data()
113116
'idea_id' => 4,
114117
'duplicate_id' => 'foo',
115118
'rfc_link' => 'https://www.phpbb.com/phpBB/viewtopic.php?foo',
119+
'implemented_version' => 'foo',
116120
'ticket_id' => 'foo',
117121
'idea_title' => '',
118122
), false
@@ -122,6 +126,7 @@ public function idea_attribute_test_data()
122126
'idea_id' => 5,
123127
'duplicate_id' => array(1),
124128
'rfc_link' => 'foobar',
129+
'implemented_version' => '1',
125130
'ticket_id' => array(1),
126131
'idea_title' => '',
127132
), false
@@ -149,6 +154,16 @@ public function test_set_rfc($data, $expected)
149154
$this->set_attribute_test('set_rfc', 'rfc_link', $data, $expected);
150155
}
151156

157+
/**
158+
* Test set_implemented()
159+
*
160+
* @dataProvider idea_attribute_test_data
161+
*/
162+
public function test_set_implemented($data, $expected)
163+
{
164+
$this->set_attribute_test('set_implemented', 'implemented_version', $data, $expected);
165+
}
166+
152167
/**
153168
* Test set_ticket()
154169
*

0 commit comments

Comments
 (0)