Merge pull request #130 from VSEphpbb/maintenance

Some general maintenance

Author: iMattPro

.editorconfig

@@ -13,7 +13,7 @@ <h3>{{ lang('WARNING') }}</h3>
 	</div>
 {% endif %}
 
-<form id="acp_phpbb_ideas_settings" method="post" action="{{ U_ACTION }}">
+<form id="acp_phpbb_ideas_settings" method="post" action="{{ U_ACTION }}" data-ajax="true">
 	<fieldset>
 		<legend>{{ lang('ACP_PHPBB_IDEAS_SETTINGS') }}</legend>
 		<dl>

adm/style/acp_phpbb_ideas.html

@@ -22,16 +22,21 @@ class ext extends \phpbb\extension\base
 {
 	/**
 	 * Check whether or not the extension can be enabled.
-	 * The current phpBB version should meet or exceed
-	 * the minimum version required by this extension:
 	 *
-	 * Requires phpBB 3.2.1 due to use of $event->update_subarray()
+	 * Requires phpBB >= 3.2.1 due to use of $event->update_subarray()
+	 * Also incompatible with SQLite which does not support SQRT in SQL queries
 	 *
 	 * @return bool
 	 * @access public
 	 */
 	public function is_enableable()
 	{
-		return phpbb_version_compare(PHPBB_VERSION, '3.2.1', '>=');
+		if (phpbb_version_compare(PHPBB_VERSION, '3.2.1', '<'))
+		{
+			return false;
+		}
+
+		$db = $this->container->get('dbal.conn');
+		return ($db->get_sql_layer() !== 'sqlite3');
 	}
 }

ext.php

@@ -749,20 +749,6 @@ public function submit($data)
 		return $idea_id;
 	}
 
-	/**
-	 * Preview a new idea.
-	 *
-	 * @param string $message The description of the idea.
-	 *
-	 * @return string The idea parsed for display in preview.
-	 */
-	public function preview($message)
-	{
-		$uid = $bitfield = $flags = '';
-		generate_text_for_storage($message, $uid, $bitfield, $flags, true, true, true);
-		return generate_text_for_display($message, $uid, $bitfield, $flags);
-	}
-
 	/**
 	 * Deletes an idea and the topic to go with it.
 	 *