Display loading indicators during ajax operations (voting, etc)

Author: iMattPro

styles/prosilver/template/ideas.js

@@ -32,7 +32,7 @@
 			voteDown: $('.minivotedown'),
 			voteUp: $('.minivoteup'),
 			voteRemove: $('#vote-remove')
-		};
+		}, $loadingIndicator;
 
 	function voteSuccess(result, $this) {
 		if (typeof result === 'string') {
@@ -76,11 +76,12 @@
 			return false;
 		}
 
+		showLoadingIndicator();
 		$.get(url, {v: vote}, function(data) {
 			voteSuccess(data, $this);
 			resetVoteButtons($this);
 			$obj.voteRemove.show();
-		}).fail(voteFailure);
+		}).fail(voteFailure).always(hideLoadingIndicator);
 	});
 
 	$obj.votes.on('click', function(e) {
@@ -101,11 +102,12 @@
 			return false;
 		}
 
+		showLoadingIndicator();
 		$.get(url, function(data) {
 			voteSuccess(data, $this);
 			resetVoteButtons();
 			$obj.voteRemove.hide();
-		}).fail(voteFailure);
+		}).fail(voteFailure).always(hideLoadingIndicator);
 	});
 
 	$obj.status.on('change', function() {
@@ -119,6 +121,7 @@
 			return;
 		}
 
+		showLoadingIndicator();
 		$.get($this.attr('data-url'), data, function(res) {
 			if (res) {
 				var anchor = $this.prev('a'),
@@ -134,7 +137,7 @@
 				$obj.duplicateToggle.toggle(idea_is_duplicate());
 				$obj.implementedToggle.toggle(idea_is_implemented());
 			}
-		});
+		}).always(hideLoadingIndicator);
 	});
 
 	$obj.rfcEdit.on('click', function(e) {
@@ -159,6 +162,7 @@
 				return;
 			}
 
+			showLoadingIndicator();
 			$.get(url, {rfc: value}, function(res) {
 				if (res) {
 					$obj.rfcLink.text(value)
@@ -172,7 +176,7 @@
 
 					$obj.rfcEdit.toggleAddEdit(value);
 				}
-			});
+			}).always(hideLoadingIndicator);
 		} else if (e.keyCode === keymap.ESC) {
 			e.preventDefault();
 
@@ -213,6 +217,7 @@
 				value = 'PHPBB3-' + info[1];
 			}
 
+			showLoadingIndicator();
 			$.get(url, {ticket: value && info[1]}, function(res) {
 				if (res) {
 					$obj.ticketLink.text(value)
@@ -227,7 +232,7 @@
 					$obj.ticketEdit.toggleAddEdit(value);
 				}
 
-			});
+			}).always(hideLoadingIndicator);
 		} else if (e.keyCode === keymap.ESC) {
 			e.preventDefault();
 
@@ -263,6 +268,7 @@
 				return;
 			}
 
+			showLoadingIndicator();
 			$.get(url, {duplicate: Number(value)}, function(res) {
 				if (res) {
 					if (value) {
@@ -283,7 +289,7 @@
 
 					$obj.duplicateEdit.toggleAddEdit(value);
 				}
-			});
+			}).always(hideLoadingIndicator);
 		} else if (e.keyCode === keymap.ESC) {
 			e.preventDefault();
 
@@ -320,6 +326,7 @@
 				return;
 			}
 
+			showLoadingIndicator();
 			$.get(url, {implemented: value}, function(res) {
 				if (res) {
 					$obj.implementedVersion.text(value);
@@ -332,7 +339,7 @@
 
 					$obj.implementedEdit.toggleAddEdit(value);
 				}
-			});
+			}).always(hideLoadingIndicator);
 		} else if (e.keyCode === keymap.ESC) {
 			e.preventDefault();
 
@@ -408,4 +415,14 @@
 		}
 	}
 
+	function showLoadingIndicator() {
+		$loadingIndicator = phpbb.loadingIndicator();
+	}
+
+	function hideLoadingIndicator() {
+		if ($loadingIndicator && $loadingIndicator.is(':visible')) {
+			$loadingIndicator.fadeOut(phpbb.alertTime);
+		}
+	}
+
 })(jQuery); // Avoid conflicts with other libraries