Skip to content

Commit 8f406ea

Browse files
committed
Comment update
1 parent 21d86c4 commit 8f406ea

1 file changed

Lines changed: 6 additions & 5 deletions

File tree

factory/ideas.php

Lines changed: 6 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -222,17 +222,18 @@ protected function query_sort($sort, $direction)
222222
}
223223

224224
/**
225-
* Update $sql property with additional SQL statements that will filter
226-
* the query to get ideas within or without certain statuses.
225+
* Update $sql property with additional SQL statements to filter ideas
226+
* by status. If $status is given we'll get those ideas. If no $status
227+
* is given, the default is to get all ideas excluding Duplicates, Invalid
228+
* and Implemented statuses (because they are considered done & dusted,
229+
* if they were gases they'd be inert).
227230
*
228-
* @param array|int $status The id of the status(es) to load
231+
* @param array|int $status The id(s) of the status(es) to load
229232
*
230233
* @return \phpbb\ideas\factory\ideas $this For chaining calls
231234
*/
232235
protected function query_status($status = [])
233236
{
234-
// If we are given some statuses, get ideas from those. Otherwise the default is
235-
// to get ideas excluding Duplicates, Invalid and Implemented statuses.
236237
$this->sql['WHERE'][] = !empty($status) ? $this->db->sql_in_set('i.idea_status', $status) : $this->db->sql_in_set(
237238
'i.idea_status', [self::$statuses['IMPLEMENTED'], self::$statuses['DUPLICATE'], self::$statuses['INVALID'],
238239
], true);

0 commit comments

Comments
 (0)