Refactor get status name code

Author: iMattPro

controller/list_controller.php

@@ -56,7 +56,7 @@ public function ideas_list($sort)
 		}
 
 		// Set the name for displaying in the template
-		$status_name = 'LIST_' . strtoupper($status > 0 ? array_search($status, ext::$statuses) : $sort);
+		$status_name = 'LIST_' . ($status > 0 ? ext::status_name($status) : strtoupper($sort));
 		$status_name = $this->language->is_set($status_name) ? $this->language->lang($status_name) : '';
 
 		// For special case where we want to request ALL ideas,

event/listener.php

@@ -198,7 +198,7 @@ public function show_idea($event)
 			'IDEA_VOTES_DOWN'	=> $idea['idea_votes_down'],
 			'IDEA_POINTS'		=> $points,
 			'IDEA_STATUS_ID'	=> $idea['idea_status'],
-			'IDEA_STATUS_NAME'	=> $this->idea->get_status_from_id($idea['idea_status']),
+			'IDEA_STATUS_NAME'	=> $this->language->lang(ext::status_name($idea['idea_status'])),
 
 			'IDEA_DUPLICATE'	=> $idea['duplicate_id'] ? $this->idea->get_title($idea['duplicate_id']) : '',
 			'IDEA_RFC'			=> $idea['rfc_link'],

ext.php

@@ -40,6 +40,20 @@ class ext extends \phpbb\extension\base
 		'INVALID'		=> 5,
 	);
 
+	/**
+	 * Return the status name from the status ID.
+	 *
+	 * @param int $id ID of the status.
+	 *
+	 * @return string The status name.
+	 * @static
+	 * @access public
+	 */
+	public static function status_name($id)
+	{
+		return array_flip(self::$statuses)[$id];
+	}
+
 	/**
 	 * Check whether or not the extension can be enabled.
 	 *

factory/base.php

@@ -77,18 +77,6 @@ public function __construct(auth $auth, config $config, driver_interface $db, la
 		$this->table_topics = $table_topics;
 	}
 
-	/**
-	 * Returns the status name from the status ID specified.
-	 *
-	 * @param int $id ID of the status.
-	 *
-	 * @return string|bool The status name if it exists, false otherwise.
-	 */
-	public function get_status_from_id($id)
-	{
-		return $this->language->lang(array_search($id, ext::$statuses));
-	}
-
 	/**
 	 * Helper method for inserting new idea data
 	 *