Remove specific view online event for the old post controller

Author: iMattPro

event/listener.php

@@ -279,20 +279,8 @@ public function adjust_quickmod_tools($event)
 	 */
 	public function viewonline_ideas($event)
 	{
-		if ($event['on_page'][1] === 'app')
-		{
-			if (strrpos($event['row']['session_page'], 'app.' . $this->php_ext . '/ideas/post') === 0)
-			{
-				$event['location'] = $this->language->lang('POSTING_NEW_IDEA');
-				$event['location_url'] = $this->helper->route('phpbb_ideas_index_controller');
-			}
-			else if (strrpos($event['row']['session_page'], 'app.' . $this->php_ext . '/ideas') === 0)
-			{
-				$event['location'] = $this->language->lang('VIEWING_IDEAS');
-				$event['location_url'] = $this->helper->route('phpbb_ideas_index_controller');
-			}
-		}
-		else if ($event['on_page'][1] === 'viewtopic' && $event['row']['session_forum_id'] == $this->config['ideas_forum_id'])
+		if (($event['on_page'][1] === 'app' && strrpos($event['row']['session_page'], 'app.' . $this->php_ext . '/ideas') === 0) ||
+			($event['on_page'][1] === 'viewtopic' && $event['row']['session_forum_id'] == $this->config['ideas_forum_id']))
 		{
 			$event['location'] = $this->language->lang('VIEWING_IDEAS');
 			$event['location_url'] = $this->helper->route('phpbb_ideas_index_controller');

tests/event/listener_test.php

@@ -215,19 +215,6 @@ public function viewonline_data()
 				'phpbb_ideas_index_controller#a:0:{}',
 				'VIEWING_IDEAS',
 			),
-			// test when on_page is app and session_page is for ideas/post
-			array(
-				array(
-					1 => 'app',
-				),
-				array(
-					'session_page' => 'app.' . $phpEx . '/ideas/post'
-				),
-				'$location_url',
-				'$location',
-				'phpbb_ideas_index_controller#a:0:{}',
-				'POSTING_NEW_IDEA',
-			),
 			// test when viewing an idea topic (any topic in forum id 2)
 			array(
 				array(