Code cleaning and fixes

clean 2

Author: iMattPro

factory/ideas.php

@@ -168,7 +168,7 @@ public function get_ideas($number = 10, $sort = 'date', $sort_direction = 'DESC'
 		{
 			$sql = 'SELECT COUNT(i.idea_id) as num_ideas
 				FROM ' . $this->table_ideas . ' i
-       			INNER JOIN ' . $this->table_topics . " t 
+       			INNER JOIN ' . $this->table_topics . " t
        				ON i.topic_id = t.topic_id
 				WHERE $where";
 			$result = $this->db->sql_query($sql);
@@ -183,7 +183,7 @@ public function get_ideas($number = 10, $sort = 'date', $sort_direction = 'DESC'
 		{
 			$sql = 'SELECT t.topic_last_post_time, t.topic_status, t.topic_visibility, i.*
 				FROM ' . $this->table_ideas . ' i
-				INNER JOIN ' . $this->table_topics . " t 
+				INNER JOIN ' . $this->table_topics . " t
 					ON i.topic_id = t.topic_id
 				WHERE $where
 				ORDER BY " . $this->db->sql_escape($sortby);
@@ -196,12 +196,12 @@ public function get_ideas($number = 10, $sort = 'date', $sort_direction = 'DESC'
 				((i.idea_votes_up + 1.9208) / (i.idea_votes_up + i.idea_votes_down) -
 	            1.96 * SQRT((i.idea_votes_up * i.idea_votes_down) / (i.idea_votes_up + i.idea_votes_down) + 0.9604) /
 	            (i.idea_votes_up + i.idea_votes_down)) / (1 + 3.8416 / (i.idea_votes_up + i.idea_votes_down))
-	            AS ci_lower_bound
-       				FROM ' . $this->table_ideas . ' i
-       				INNER JOIN ' . $this->table_topics . " t 
-       					ON i.topic_id = t.topic_id
-       				WHERE $where
-       			ORDER BY ci_lower_bound " . $this->db->sql_escape($sort_direction);
+				AS ci_lower_bound
+					FROM ' . $this->table_ideas . ' i
+					INNER JOIN ' . $this->table_topics . " t
+						ON i.topic_id = t.topic_id
+					WHERE $where
+				ORDER BY ci_lower_bound " . $this->db->sql_escape($sort_direction);
 		}
 
 		$result = $this->db->sql_query_limit($sql, $number, $start);
@@ -210,10 +210,7 @@ public function get_ideas($number = 10, $sort = 'date', $sort_direction = 'DESC'
 
 		if (count($rows))
 		{
-			$topic_ids = array_map(function($row) {
-				return $row['topic_id'];
-			}, $rows);
-
+			$topic_ids = array_column($rows, 'topic_id');
 			$idea_ids = array_column($rows, 'idea_id');
 
 			$topic_tracking_info = get_complete_topic_tracking((int) $this->config['ideas_forum_id'], $topic_ids);
@@ -224,6 +221,7 @@ public function get_ideas($number = 10, $sort = 'date', $sort_direction = 'DESC'
 				$row['read'] = !(isset($topic_tracking_info[$row['topic_id']]) && $row['topic_last_post_time'] > $topic_tracking_info[$row['topic_id']]);
 				$row['u_voted'] = isset($user_voting_info[$row['idea_id']]) ? (string) $user_voting_info[$row['idea_id']] : '';
 			}
+			unset ($row);
 		}
 
 		return $rows;
@@ -725,7 +723,7 @@ public function delete_orphans()
 	{
 		// Find any orphans
 		$sql = 'SELECT idea_id FROM ' . $this->table_ideas . '
- 			WHERE topic_id NOT IN (SELECT t.topic_id 
+ 			WHERE topic_id NOT IN (SELECT t.topic_id
  			FROM ' . $this->table_topics . ' t
  				WHERE t.forum_id = ' . (int) $this->config['ideas_forum_id'] . ')';
 		$result = $this->db->sql_query($sql);