Skip to content

Commit 0d0a44c

Browse files
authored
Merge pull request #81 from VSEphpbb/vse-patch
Remove unused log dependency
2 parents e4dce1a + 78a943b commit 0d0a44c

3 files changed

Lines changed: 1 addition & 15 deletions

File tree

config/services.yml

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -68,7 +68,6 @@ services:
6868
- '@config'
6969
- '@dbal.conn'
7070
- '@language'
71-
- '@log'
7271
- '@user'
7372
- '%tables.ideas_ideas%'
7473
- '%tables.ideas_votes%'

factory/ideas.php

Lines changed: 1 addition & 7 deletions
Original file line numberDiff line numberDiff line change
@@ -13,7 +13,6 @@
1313
use phpbb\config\config;
1414
use phpbb\db\driver\driver_interface;
1515
use phpbb\language\language;
16-
use phpbb\log\log;
1716
use phpbb\user;
1817

1918
class ideas
@@ -46,9 +45,6 @@ class ideas
4645
/** @var language */
4746
protected $language;
4847

49-
/** @var log */
50-
protected $log;
51-
5248
/* @var user */
5349
protected $user;
5450

@@ -74,19 +70,17 @@ class ideas
7470
* @param config $config
7571
* @param driver_interface $db
7672
* @param language $language
77-
* @param log $log
7873
* @param user $user
7974
* @param string $table_ideas
8075
* @param string $table_votes
8176
* @param string $table_topics
8277
* @param string $phpEx
8378
*/
84-
public function __construct(config $config, driver_interface $db, language $language, log $log, user $user, $table_ideas, $table_votes, $table_topics, $phpEx)
79+
public function __construct(config $config, driver_interface $db, language $language, user $user, $table_ideas, $table_votes, $table_topics, $phpEx)
8580
{
8681
$this->config = $config;
8782
$this->db = $db;
8883
$this->language = $language;
89-
$this->log = $log;
9084
$this->user = $user;
9185

9286
$this->php_ext = $phpEx;

tests/ideas/ideas_base.php

Lines changed: 0 additions & 7 deletions
Original file line numberDiff line numberDiff line change
@@ -26,9 +26,6 @@ static protected function setup_extensions()
2626
/** @var \phpbb\language\language */
2727
protected $lang;
2828

29-
/** @var \phpbb\log\log */
30-
protected $log;
31-
3229
/** @var \phpbb\user */
3330
protected $user;
3431

@@ -60,9 +57,6 @@ public function setUp()
6057
$this->lang,
6158
'\phpbb\datetime'
6259
));
63-
$this->log = $this->getMockBuilder('\phpbb\log\log')
64-
->disableOriginalConstructor()
65-
->getMock();
6660
$this->php_ext = $phpEx;
6761
$request = $this->getMock('\phpbb\request\request');
6862
}
@@ -78,7 +72,6 @@ protected function get_ideas_object()
7872
$this->config,
7973
$this->db,
8074
$this->lang,
81-
$this->log,
8275
$this->user,
8376
'phpbb_ideas_ideas',
8477
'phpbb_ideas_votes',

0 commit comments

Comments
 (0)