Skip to content

Commit c6ea224

Browse files
committed
Remove dir since it is not implemented
fix test
1 parent 9b83d9e commit c6ea224

3 files changed

Lines changed: 1 addition & 10 deletions

File tree

config/services.yml

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -62,6 +62,5 @@ services:
6262
class: phpbb\webpushnotifications\controller\manifest
6363
arguments:
6464
- '@config'
65-
- '@language'
6665
- '@path_helper'
6766
- '@user'

controller/manifest.php

Lines changed: 1 addition & 8 deletions
Original file line numberDiff line numberDiff line change
@@ -12,7 +12,6 @@
1212

1313
use phpbb\config\config;
1414
use phpbb\exception\http_exception;
15-
use phpbb\language\language;
1615
use phpbb\path_helper;
1716
use phpbb\user;
1817
use phpbb\webpushnotifications\ext;
@@ -24,9 +23,6 @@ class manifest
2423
/** @var config */
2524
protected $config;
2625

27-
/** @var language */
28-
protected $language;
29-
3026
/** @var path_helper */
3127
protected $path_helper;
3228

@@ -38,14 +34,12 @@ class manifest
3834
*
3935
* @param config $config
4036
* @param path_helper $path_helper
41-
* @param language $language
4237
* @param user $user
4338
*/
44-
public function __construct(config $config, language $language, path_helper $path_helper, user $user)
39+
public function __construct(config $config, path_helper $path_helper, user $user)
4540
{
4641
$this->config = $config;
4742
$this->path_helper = $path_helper;
48-
$this->language = $language;
4943
$this->user = $user;
5044
}
5145

@@ -73,7 +67,6 @@ public function handle(): JsonResponse
7367
'short_name' => $pwa_short_name ?: utf8_substr($sitename, 0, 12),
7468
'display' => 'standalone',
7569
'orientation' => 'portrait',
76-
'dir' => $this->language->lang('DIRECTION'),
7770
'start_url' => $board_path,
7871
'scope' => $board_path,
7972
];

tests/functional/functional_test.php

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -120,7 +120,6 @@ public function test_manifest()
120120
'short_name' => 'yourdomain',
121121
'display' => 'standalone',
122122
'orientation' => 'portrait',
123-
'dir' => 'ltr',
124123
'start_url' => '/',
125124
'scope' => '/',
126125
];

0 commit comments

Comments
 (0)