Improve disabled state JS

Signed-off-by: Matt Friedman <maf675@gmail.com>

Author: iMattPro

styles/all/template/webpush.js

@@ -51,8 +51,7 @@ function PhpbbWebpush() {
 
 		// Service workers are only supported in secure context
 		if (window.isSecureContext !== true) {
-			subscribeButton.disabled = true;
-			handleDisabledState();
+			setDisabledState();
 			return;
 		}
 
@@ -67,30 +66,30 @@ function PhpbbWebpush() {
 				.catch(error => {
 					console.info(error);
 					// Service worker could not be registered
-					subscribeButton.disabled = true;
+					setDisabledState();
 				});
 		} else {
-			subscribeButton.disabled = true;
+			setDisabledState();
 		}
-		handleDisabledState();
 	};
 
 	/**
 	 * If subscribing is disabled, hide dropdown toggle and update subscribe button text
 	 *
 	 * @return void
 	 */
-	function handleDisabledState() {
-		if (subscribeButton.disabled) {
-			const notificationList = document.getElementById('notification_list');
-			const footer = notificationList.querySelector('.wpn-notification-dropdown-footer');
-			if (footer) {
-				footer.style.display = 'none';
-			}
+	function setDisabledState() {
+		subscribeButton.disabled = true;
 
-			if (subscribeButton.type === 'submit' || subscribeButton.classList.contains('button')) {
-				subscribeButton.value = subscribeButton.getAttribute('data-disabled-msg');
-			}
+		const notificationList = document.getElementById('notification_list');
+		const subscribeToggle = notificationList.querySelector('.wpn-notification-dropdown-footer');
+
+		if (subscribeToggle) {
+			subscribeToggle.style.display = 'none';
+		}
+
+		if (subscribeButton.type === 'submit' || subscribeButton.classList.contains('button')) {
+			subscribeButton.value = subscribeButton.getAttribute('data-disabled-msg');
 		}
 	}