Fix confusing conditional order

iMattPro · iMattPro · commit 92c52d92b759 · 2024-06-08T18:29:46.000-07:00
Signed-off-by: Matt Friedman &lt;maf675@gmail.com&gt;
diff --git a/notification/method/webpush.php b/notification/method/webpush.php
@@ -216,7 +216,7 @@ protected function notify_using_webpush(): void
 
 			$user_subscriptions = $user_subscription_map[$notification->user_id] ?? [];
 
-			if ($user['user_type'] == USER_INACTIVE && $user['user_inactive_reason'] == INACTIVE_MANUAL
+			if (($user['user_type'] == USER_INACTIVE && $user['user_inactive_reason'] == INACTIVE_MANUAL)
 				|| empty($user_subscriptions))
 			{
 				continue;

Original file line number	Diff line number	Diff line change
`@@ -216,7 +216,7 @@ protected function notify_using_webpush(): void`
`216`	`216`
`217`	`217`	`$user_subscriptions = $user_subscription_map[$notification->user_id] ?? [];`
`218`	`218`
`219`		`- if ($user['user_type'] == USER_INACTIVE && $user['user_inactive_reason'] == INACTIVE_MANUAL`
	`219`	`+ if (($user['user_type'] == USER_INACTIVE && $user['user_inactive_reason'] == INACTIVE_MANUAL)`
`220`	`220`	`\|\| empty($user_subscriptions))`
`221`	`221`	`{`
`222`	`222`	`continue;`