Add better checks for required PHP extensions

Signed-off-by: Matt Friedman <maf675@gmail.com>

Author: iMattPro

composer.json

@@ -24,26 +24,33 @@
     ],
     "require": {
         "php": ">=7.3",
+        "ext-curl": "*",
+        "ext-json": "*",
+        "ext-mbstring": "*",
+        "ext-openssl": "*",
         "composer/installers": "~1.0",
         "minishlink/web-push": "^7.0"
     },
     "require-dev": {
         "phing/phing": "~2.4"
     },
-	"config": {
-		"allow-plugins": {
-			"composer/installers": true
-		}
-	},
-	"extra": {
+    "suggest": {
+        "ext-gmp": "Optional but better for performance"
+    },
+    "config": {
+        "allow-plugins": {
+            "composer/installers": true
+        }
+    },
+    "extra": {
         "display-name": "phpBB Browser Push Notifications",
         "soft-require": {
             "phpbb/phpbb": ">=3.3.12,<4.0.0@dev"
-		},
-		"version-check": {
-			"host": "imattpro.github.io",
-			"directory": "/version",
-			"filename": "webpushnotifications.json"
+        },
+        "version-check": {
+            "host": "imattpro.github.io",
+            "directory": "/version",
+            "filename": "webpushnotifications.json"
         }
     }
 }

ext.php

@@ -29,7 +29,10 @@ class ext extends \phpbb\extension\base
 	 */
 	public function is_enableable()
 	{
-		return $this->check_phpbb_version()->check_php_version()->result();
+		return $this->check_phpbb_version()
+			->check_php_version()
+			->check_php_requirements()
+			->result();
 	}
 
 	/**
@@ -67,6 +70,24 @@ protected function check_php_version()
 		return $this;
 	}
 
+	/**
+	 * Check the installed PHP extensions meet this extension's requirements.
+	 *
+	 * @return \phpbb\webpushnotifications\ext
+	 */
+	protected function check_php_requirements()
+	{
+		foreach (['curl', 'mbstring', 'openssl'] as $extension)
+		{
+			if (!extension_loaded($extension))
+			{
+				$this->errors[] = ['PHP_EXT_MISSING', $extension];
+			}
+		}
+
+		return $this;
+	}
+
 	/**
 	 * Return the is_enableable result. Either true, or the best enable failed
 	 * response for the current phpBB environment: array of error messages
@@ -85,7 +106,9 @@ protected function result()
 		{
 			$language = $this->container->get('language');
 			$language->add_lang('install', 'phpbb/webpushnotifications');
-			return array_map([$language, 'lang'], $this->errors);
+			return array_map(static function($error) use ($language) {
+				return call_user_func_array([$language, 'lang'], (array) $error);
+			}, $this->errors);
 		}
 
 		return false;

language/en/install.php

@@ -38,7 +38,8 @@
 //
 
 $lang = array_merge($lang, [
-	'PHPBB_VERSION_MAX_ERROR'	=> 'This extension can not be installed on your board. You are using phpBB 4, which already contains the features in this extension.',
-	'PHPBB_VERSION_MIN_ERROR'	=> 'This extension is not compatible with your board. You must be using phpBB 3.3.12 or newer.',
-	'PHP_VERSION_ERROR'	=> 'This extension is not compatible with your server. Your server must be running PHP 7.3 or newer.',
+	'PHPBB_VERSION_MAX_ERROR'	=> 'This extension can not be installed on this board. This is a phpBB 4 board, which already contains the features in this extension.',
+	'PHPBB_VERSION_MIN_ERROR'	=> 'phpBB 3.3.12 or newer is required.',
+	'PHP_VERSION_ERROR'			=> 'PHP 7.3 or newer is required.',
+	'PHP_EXT_MISSING'			=> 'The “%s” extension for PHP must be installed on this server.',
 ]);