Ensure subscription handling happens before table deletion

iMattPro · iMattPro · commit 1c6781ac54fe · 2024-05-13T12:35:00.000-07:00
Signed-off-by: Matt Friedman &lt;maf675@gmail.com&gt;
diff --git a/migrations/add_webpush.php b/migrations/add_webpush.php
@@ -21,7 +21,7 @@ public function effectively_installed(): bool
 
 	public static function depends_on()
 	{
-		return ['\phpbb\webpushnotifications\migrations\handle_subscriptions'];
+		return ['\phpbb\db\migration\data\v33x\v3312rc1'];
 	}
 
 	public function update_schema(): array
diff --git a/migrations/handle_subscriptions.php b/migrations/handle_subscriptions.php
@@ -14,6 +14,11 @@
 
 class handle_subscriptions extends migration
 {
+	public static function depends_on()
+	{
+		return ['\phpbb\webpushnotifications\migrations\add_webpush'];
+	}
+
 	public function effectively_installed()
 	{
 		return !$this->db_tools->sql_table_exists($this->table_prefix . 'wpn_notification_push');

Original file line number	Diff line number	Diff line change
`@@ -21,7 +21,7 @@ public function effectively_installed(): bool`
`21`	`21`
`22`	`22`	`public static function depends_on()`
`23`	`23`	`{`
`24`		`- return ['\phpbb\webpushnotifications\migrations\handle_subscriptions'];`
	`24`	`+ return ['\phpbb\db\migration\data\v33x\v3312rc1'];`
`25`	`25`	`}`
`26`	`26`
`27`	`27`	`public function update_schema(): array`
Original file line number	Diff line number	Diff line change
`@@ -14,6 +14,11 @@`
`14`	`14`
`15`	`15`	`class handle_subscriptions extends migration`
`16`	`16`	`{`
	`17`	`+ public static function depends_on()`
	`18`	`+ {`
	`19`	`+ return ['\phpbb\webpushnotifications\migrations\add_webpush'];`
	`20`	`+ }`
	`21`	`+`
`17`	`22`	`public function effectively_installed()`
`18`	`23`	`{`
`19`	`24`	`return !$this->db_tools->sql_table_exists($this->table_prefix . 'wpn_notification_push');`