Fix up handling of codecov variables

Author: iMattPro

.github/workflows/tests.yml

@@ -52,7 +52,6 @@ env:
     IMAGE_ICC: ${{ inputs.IMAGE_ICC == '1' && '1' || '0' }}
     EPV: ${{ inputs.EPV == '1' && '1' || '0' }}
     EXECUTABLE_FILES: ${{ inputs.EXECUTABLE_FILES == '1' && '1' || '0' }}
-    CODECOV: ${{ inputs.CODECOV == '1' && '1' || '0' }}
     PHPBB_BRANCH: ${{ inputs.PHPBB_BRANCH }}
 
 jobs:
@@ -150,8 +149,8 @@ jobs:
                       db: "mysql:5.6"
                     - php: '7.2'
                       db: "mysql:5.7"
-                      COVERAGE: 1
-                      db_alias: "mysql:5.7 with Coverage"
+                      COVERAGE: ${{ inputs.CODECOV == '1' && '1' || '0' }}
+                      db_alias: ${{ inputs.CODECOV == '1' && 'mysql:5.7 with Coverage' || 'mysql:5.7' }}
                     - php: '7.3'
                       db: "mysql:5.7"
                     - php: '7.4'
@@ -220,7 +219,7 @@ jobs:
               with:
                   php-version: ${{ matrix.php }}
                   extensions: dom, curl, libxml, mbstring, zip, pcntl, pdo, mysqli, sqlite, pdo_sqlite, intl, gd, exif, iconv, sqlsrv, pdo_sqlsrv, ldap
-                  coverage: ${{ matrix.COVERAGE == 1 && env.CODECOV == '1' && 'xdebug' || 'none' }}
+                  coverage: ${{ matrix.COVERAGE == '1' && 'xdebug' || 'none' }}
 
             - name: Setup environment for phpBB
               env:
@@ -240,7 +239,7 @@ jobs:
             - name: Setup PHPUnit files
               env:
                   DB: ${{steps.database-type.outputs.db}}
-                  COVERAGE: ${{ matrix.COVERAGE == 1 && env.CODECOV == '1' && '1' || '0' }}
+                  COVERAGE: ${{ matrix.COVERAGE == '1' && '1' || '0' }}
               run: |
                   if [ $COVERAGE == '1' ]
                   then
@@ -253,7 +252,7 @@ jobs:
             - name: Run unit tests
               env:
                   DB: ${{steps.database-type.outputs.db}}
-                  COVERAGE: ${{ matrix.COVERAGE == 1 && env.CODECOV == '1' && '1' || '0' }}
+                  COVERAGE: ${{ matrix.COVERAGE == '1' && '1' || '0' }}
               run: |
                   if [ $COVERAGE == '1' ]
                   then
@@ -264,7 +263,7 @@ jobs:
               working-directory: ./phpBB3
 
             - name: Send code coverage
-              if: ${{ matrix.COVERAGE == 1 && env.CODECOV == '1' }}
+              if: ${{ matrix.COVERAGE == '1' }}
               uses: codecov/codecov-action@v5
               with:
                   token: ${{ secrets.CODECOV_TOKEN }}