Skip to content

Commit ceb2d38

Browse files
committed
Readme doc tweaks
1 parent b1bf056 commit ceb2d38

1 file changed

Lines changed: 27 additions & 23 deletions

File tree

README.md

Lines changed: 27 additions & 23 deletions
Original file line numberDiff line numberDiff line change
@@ -8,8 +8,7 @@ This repository contains a pre-configured test workflow designed for phpBB exten
88

99
-[Features](#-features)
1010
- 🚀 [How to Use](#-how-to-use)
11-
-[Requirements](#-requirements)
12-
- 🛠 [Advanced Configuration Options](#-advanced-configuration-options)
11+
- 🛠 [Configuration Options](#-configuration-options)
1312
- 📊 [Code Coverage with Codecov](#-code-coverage-with-codecov)
1413

1514
## ✨ Features
@@ -18,10 +17,10 @@ This repository contains a pre-configured test workflow designed for phpBB exten
1817
- Tests against multiple database engines
1918
- Optional checks for:
2019
- PHP CodeSniffer
21-
- ICC image profiles
20+
- Image ICC profile removal
2221
- EPV (Extension Pre Validator)
23-
- Executable files
24-
- Code coverage via Codecov
22+
- Files with executable permissions
23+
- Code coverage reports via Codecov
2524

2625
## 🚀 How to Use
2726

@@ -59,15 +58,23 @@ jobs:
5958
6059
Use the branch that matches the phpBB version you're developing for.
6160
62-
- `3.3.x`: Targets the **phpBB 3.3.x** release line.
63-
- `master`: Targets the latest development version of **phpBB** (`master` branch).
61+
- `3.3.x`: Targets the phpBB 3.3.x release line.
62+
- `master`: Targets the latest development version of phpBB (`master` branch).
6463

65-
## ✅ Requirements
64+
> ‼️ Whichever branch you choose here, be sure to use the **same value** for both the `PHPBB_BRANCH` and in the `uses:` line after the `@` symbol. For example, if you're targeting the `3.3.x` branch:
65+
>
66+
> ```yaml
67+
> uses: phpbb-extensions/test-framework/.github/workflows/tests.yml@3.3.x
68+
> with:
69+
> PHPBB_BRANCH: 3.3.x
70+
> ```
71+
72+
### Requirements
6673

6774
- Your extension's package contents must be located at the root level of the repository. That is, the repository **must directly represent the package**, with all relevant files such as `composer.json`, `README`, `LICENSE`, etc. placed directly in the **root of the repository**, **not inside a subdirectory within the repository**.
6875
- Tests must be defined in your repository using PHPUnit.
6976

70-
## 🛠 Advanced Configuration Options
77+
## 🛠 Configuration Options
7178

7279
You can fine-tune this workflow with several optional arguments in the `with` section:
7380

@@ -82,46 +89,43 @@ call-tests:
8289
# OPTIONAL CONFIGURATIONS BELOW
8390
# The following arguments are optional and can be omitted if not needed.
8491
85-
# Run EPV (Extension Pre Validator) on your code? 1 or 0
92+
# Run phpBB's EPV (Extension Pre Validator)? 1 (yes) or 0 (no)
8693
# Default: 1
8794
EPV: 1
8895
89-
# Run check for executable files? 1 or 0
96+
# Check for files with executable permissions? 1 (yes) or 0 (no)
9097
# Default: 1
9198
EXECUTABLE_FILES: 1
9299
93-
# Run icc profile sniffer on your images? 1 or 0
100+
# Remove embedded ICC profiles from images? 1 (yes) or 0 (no)
94101
# Default: 1
95102
IMAGE_ICC: 1
96103
97-
# Run code sniffer on your code? 1 or 0
104+
# Run CodeSniffer to detect PHP code style issues? 1 (yes) or 0 (no)
98105
# Default: 1
99106
SNIFF: 1
100107
101-
# ADVANCED CONFIGURATIONS BELOW
102-
# The following arguments are for users that need to tweak the workflow.
103-
104-
# Set this to 0 to skip all MySQL/MariaDB tests.
108+
# Run MySQL/MariaDB tests? 1 (yes) or 0 (no)
105109
# Default: 1
106110
RUN_MYSQL_JOBS: 1
107111
108-
# Set this to 0 to skip all PostgreSQL tests.
112+
# Run PostgreSQL tests? 1 (yes) or 0 (no)
109113
# Default: 1
110114
RUN_PGSQL_JOBS: 1
111115
112-
# Set this to 0 to skip all MSSQL and SQLite3 tests.
116+
# Run MSSQL and SQLite3 tests? 1 (yes) or 0 (no)
113117
# Default: 1
114118
RUN_MSSQL_JOBS: 1
115119
116-
# Set this to 0 to skip all Windows IIS & PostgreSQL tests.
120+
# Run Windows IIS & PostgreSQL tests? 1 (yes) or 0 (no)
117121
# Default: 1
118122
RUN_WINDOWS_JOBS: 1
119123
120-
# Set this to 1 if your extension relies on NPM dependencies.
124+
# Install NPM dependencies (if your extension relies on them)? 1 (yes) or 0 (no)
121125
# Default: 0
122126
RUN_NPM_INSTALL: 0
123127
124-
# Set this to 1 if your extension relies on Composer dependencies.
128+
# Install Composer dependencies (if your extension relies on them)? 1 (yes) or 0 (no)
125129
# Default: 0
126130
RUN_COMPOSER_INSTALL: 0
127131
@@ -137,7 +141,7 @@ call-tests:
137141
# Default: '["7.2", "7.3", "7.4", "8.0", "8.1", "8.2", "8.3", "8.4"]'
138142
PHP_VERSION_MATRIX: '["7.2", "7.3", "7.4", "8.0", "8.1", "8.2", "8.3", "8.4"]'
139143
140-
# Set this to 1 to generate a code coverage report. (See documentation below.)
144+
# Generate a code coverage report (see documentation below)? 1 (yes) or 0 (no)
141145
# Default: 0
142146
CODECOV: 0
143147
```

0 commit comments

Comments
 (0)