Skip to content

Commit a7195be

Browse files
committed
Make basic test checks optional arguments
1 parent 822d769 commit a7195be

2 files changed

Lines changed: 39 additions & 22 deletions

File tree

.github/workflows/tests.yml

Lines changed: 11 additions & 7 deletions
Original file line numberDiff line numberDiff line change
@@ -6,25 +6,29 @@ on:
66
EXTNAME:
77
required: true
88
type: string
9-
SNIFF:
9+
PHPBB_BRANCH:
1010
required: true
1111
type: string
12+
SNIFF:
13+
required: false
14+
default: '1'
15+
type: string
1216
IMAGE_ICC:
13-
required: true
17+
required: false
18+
default: '1'
1419
type: string
1520
EPV:
16-
required: true
21+
required: false
22+
default: '1'
1723
type: string
1824
EXECUTABLE_FILES:
19-
required: true
25+
required: false
26+
default: '1'
2027
type: string
2128
CODECOV:
2229
required: false
2330
default: '0'
2431
type: string
25-
PHPBB_BRANCH:
26-
required: true
27-
type: string
2832
RUN_BASIC_JOBS:
2933
required: false
3034
type: string

README.md

Lines changed: 28 additions & 15 deletions
Original file line numberDiff line numberDiff line change
@@ -32,12 +32,12 @@ name: Tests
3232

3333
on:
3434
push:
35-
branches: # Run tests when commits are pushed to these branches in your repo
35+
branches: # Run tests when commits are pushed to these branches in your repo
3636
- main
3737
- master
3838
- develop
3939
- dev/*
40-
pull_request: # Run tests when pull requests are made on these branches in your repo
40+
pull_request: # Run tests when pull requests are made on these branches in your repo
4141
branches:
4242
- main
4343
- master
@@ -50,14 +50,9 @@ jobs:
5050
uses: phpbb-extensions/test-framework/.github/workflows/tests.yml@3.3.x # Must match PHPBB_BRANCH
5151
with:
5252
EXTNAME: acme/demo # Your extension vendor/package name
53-
SNIFF: 1 # Run code sniffer on your code? 1 or 0
54-
IMAGE_ICC: 1 # Run icc profile sniffer on your images? 1 or 0
55-
EPV: 1 # Run EPV (Extension Pre Validator) on your code? 1 or 0
56-
EXECUTABLE_FILES: 1 # Run check for executable files? 1 or 0
57-
CODECOV: 0 # Run code coverage via codecov? 1 or 0
5853
PHPBB_BRANCH: 3.3.x # The phpBB branch to run tests on
5954
secrets:
60-
CODECOV_TOKEN: ${{ secrets.CODECOV_TOKEN }} # Do not edit this
55+
CODECOV_TOKEN: ${{ secrets.CODECOV_TOKEN }} # Do not edit or remove this
6156
```
6257
6358
### Branches
@@ -82,15 +77,33 @@ call-tests:
8277
uses: phpbb-extensions/test-framework/.github/workflows/tests.yml@3.3.x
8378
with:
8479
EXTNAME: acme/demo # Your extension vendor/package name
85-
SNIFF: 1 # Run code sniffer on your code? 1 or 0
86-
IMAGE_ICC: 1 # Run icc profile sniffer on your images? 1 or 0
87-
EPV: 1 # Run EPV (Extension Pre Validator) on your code? 1 or 0
88-
EXECUTABLE_FILES: 1 # Run check for executable files? 1 or 0
89-
CODECOV: 0 # Run code coverage via codecov? 1 or 0
9080
PHPBB_BRANCH: 3.3.x # The phpBB branch to run tests on
9181
92-
# OPTIONAL ADVANCED CONFIGURATIONS BELOW
93-
# The following arguments are all optional and can be omitted if not needed.
82+
# OPTIONAL CONFIGURATIONS BELOW
83+
# The following arguments are optional and can be omitted if not needed.
84+
85+
# Run code sniffer on your code? 1 or 0
86+
# Default: 1
87+
SNIFF: 1
88+
89+
# Run icc profile sniffer on your images? 1 or 0
90+
# Default: 1
91+
IMAGE_ICC: 1
92+
93+
# Run EPV (Extension Pre Validator) on your code? 1 or 0
94+
# Default: 1
95+
EPV: 1
96+
97+
# Run check for executable files? 1 or 0
98+
# Default: 1
99+
EXECUTABLE_FILES: 1
100+
101+
# ADVANCED CONFIGURATIONS BELOW
102+
# The following arguments are for users that need to tweak the workflow.
103+
104+
# Set this to 1 to generate a code coverage report. (See documentation below.)
105+
# Default: 0
106+
CODECOV: 0
94107
95108
# Set this to 0 to skip all basic checks (code sniffer, EPV, etc.)
96109
# Default: 1

0 commit comments

Comments
 (0)