add tests (worker and non-worker separately because the global worker would activate for the non-worker case too

Author: henderkes

caddy/caddy_test.go

@@ -486,6 +486,142 @@ func TestPHPServerDirectiveDisableFileServer(t *testing.T) {
 	tester.AssertGetResponse("http://localhost:"+testPort+"/not-found.txt", http.StatusOK, "I am by birth a Genevese (i not set)")
 }
 
+func TestPHPServerGlobals(t *testing.T) {
+	documentRoot, _ := filepath.Abs("../testdata")
+	scriptFilename := documentRoot + string(filepath.Separator) + "server-globals.php"
+
+	tester := caddytest.NewTester(t)
+	initServer(t, tester, `
+		{
+			skip_install_trust
+			admin localhost:2999
+			http_port `+testPort+`
+			https_port 9443
+		}
+
+		localhost:`+testPort+` {
+			root ../testdata
+			php_server {
+				index server-globals.php
+			}
+		}
+		`, "caddyfile")
+
+	// Request to /en: no matching file, falls through to server-globals.php worker
+	// SCRIPT_NAME should be /server-globals.php, PHP_SELF should be /server-globals.php (no /en), PATH_INFO empty
+	tester.AssertGetResponse(
+		"http://localhost:"+testPort+"/en",
+		http.StatusOK,
+		"SCRIPT_NAME: /server-globals.php<br>"+
+			"SCRIPT_FILENAME: "+scriptFilename+"<br>"+
+			"PHP_SELF: /server-globals.php<br>"+
+			"PATH_INFO: <br>"+
+			"DOCUMENT_ROOT: "+documentRoot+"<br>"+
+			"REQUEST_URI: /en<br>",
+	)
+
+	// Request to /server-globals.php/en: explicit PHP file with path info
+	// SCRIPT_NAME should be /server-globals.php, PHP_SELF should be /server-globals.php/en, PATH_INFO should be /en
+	tester.AssertGetResponse(
+		"http://localhost:"+testPort+"/server-globals.php/en",
+		http.StatusOK,
+		"SCRIPT_NAME: /server-globals.php<br>"+
+			"SCRIPT_FILENAME: "+scriptFilename+"<br>"+
+			"PHP_SELF: /server-globals.php/en<br>"+
+			"PATH_INFO: /en<br>"+
+			"DOCUMENT_ROOT: "+documentRoot+"<br>"+
+			"REQUEST_URI: /server-globals.php/en<br>",
+	)
+}
+
+func TestWorkerPHPServerGlobals(t *testing.T) {
+	documentRoot, _ := filepath.Abs("../testdata")
+	scriptFilename := documentRoot + string(filepath.Separator) + "server-globals.php"
+	testPortNum, _ := strconv.Atoi(testPort)
+	testPortTwo := strconv.Itoa(testPortNum + 1)
+
+	tester := caddytest.NewTester(t)
+	initServer(t, tester, `
+		{
+			skip_install_trust
+			admin localhost:2999
+
+			frankenphp {
+				worker {
+					file ../testdata/server-globals.php
+					num 1
+				}
+			}
+		}
+
+		http://localhost:`+testPort+` {
+			php_server {
+				root ../testdata
+				index server-globals.php
+			}
+		}
+
+		http://localhost:`+testPortTwo+` {
+			php_server {
+				root ../testdata
+				index server-globals.php
+				worker {
+					file server-globals.php
+					num 1
+				}
+			}
+		}
+		`, "caddyfile")
+
+	// === Site 1: global worker with php_server ===
+	// because we don't specify a php file, PATH_INFO should be empty
+	tester.AssertGetResponse(
+		"http://localhost:"+testPort+"/en",
+		http.StatusOK,
+		"SCRIPT_NAME: /server-globals.php<br>"+
+			"SCRIPT_FILENAME: "+scriptFilename+"<br>"+
+			"PHP_SELF: /server-globals.php<br>"+
+			"PATH_INFO: <br>"+
+			"DOCUMENT_ROOT: "+documentRoot+"<br>"+
+			"REQUEST_URI: /en<br>",
+	)
+
+	tester.AssertGetResponse(
+		"http://localhost:"+testPort+"/server-globals.php/en",
+		http.StatusOK,
+		"SCRIPT_NAME: /server-globals.php<br>"+
+			"SCRIPT_FILENAME: "+scriptFilename+"<br>"+
+			"PHP_SELF: /server-globals.php/en<br>"+
+			"PATH_INFO: /en<br>"+
+			"DOCUMENT_ROOT: "+documentRoot+"<br>"+
+			"REQUEST_URI: /server-globals.php/en<br>",
+	)
+
+	// === Site 2: php_server with its own worker ===
+	// because we specify a php file, PATH_INFO should be /en
+	tester.AssertGetResponse(
+		"http://localhost:"+testPortTwo+"/en",
+		http.StatusOK,
+		"SCRIPT_NAME: /server-globals.php<br>"+
+			"SCRIPT_FILENAME: "+scriptFilename+"<br>"+
+			"PHP_SELF: /server-globals.php<br>"+
+			"PATH_INFO: <br>"+
+			"DOCUMENT_ROOT: "+documentRoot+"<br>"+
+			"REQUEST_URI: /en<br>",
+	)
+
+	tester.AssertGetResponse(
+		"http://localhost:"+testPortTwo+"/server-globals.php/en",
+		http.StatusOK,
+		"SCRIPT_NAME: /server-globals.php<br>"+
+			"SCRIPT_FILENAME: "+scriptFilename+"<br>"+
+			"PHP_SELF: /server-globals.php/en<br>"+
+			"PATH_INFO: /en<br>"+
+			"DOCUMENT_ROOT: "+documentRoot+"<br>"+
+			"REQUEST_URI: /server-globals.php/en<br>",
+	)
+}
+
 func TestMetrics(t *testing.T) {
 	var wg sync.WaitGroup
 	tester := caddytest.NewTester(t)

testdata/server-globals.php

@@ -0,0 +1,21 @@
+<?php
+
+ignore_user_abort(true);
+
+$handler = static function() {
+    echo "SCRIPT_NAME: " . ($_SERVER['SCRIPT_NAME'] ?? '(not set)') . "<br>";
+    echo "SCRIPT_FILENAME: " . ($_SERVER['SCRIPT_FILENAME'] ?? '(not set)') . "<br>";
+    echo "PHP_SELF: " . ($_SERVER['PHP_SELF'] ?? '(not set)') . "<br>";
+    echo "PATH_INFO: " . ($_SERVER['PATH_INFO'] ?? '(not set)') . "<br>";
+    echo "DOCUMENT_ROOT: " . ($_SERVER['DOCUMENT_ROOT'] ?? '(not set)') . "<br>";
+    echo "REQUEST_URI: " . ($_SERVER['REQUEST_URI'] ?? '(not set)') . "<br>";
+};
+
+if (isset($_SERVER['FRANKENPHP_WORKER'])) {
+    for ($nbRequests = 0, $running = true; $running; ++$nbRequests) {
+        $running = \frankenphp_handle_request($handler);
+        gc_collect_cycles();
+    }
+} else {
+    $handler();
+}