Merge pull request #10 from HossamSaberr/master

Refactor: Clean up dead code and align copy with standard Pharo lifecycle

Author: jordanmontt

src/Containers-KeyedTree-Tests/CTKeyedTreeTest.class.st

@@ -215,6 +215,29 @@ CTKeyedTreeTest >> testCopy [
 	self assert: (c includesKey: #new)
 ]
 
+{ #category : 'tests' }
+CTKeyedTreeTest >> testDeepCopyStateNotShared [
+	| original clone |
+	original := CTKeyedTree new
+		at: #config put: (CTKeyedTree new 
+			at: #color put: 'red'; 
+			yourself);
+		yourself.
+		
+	clone := original copy.
+	
+	"Verify they have equal values but are different objects in memory before mutation"
+	self assert: original equals: clone.
+	self deny: original == clone.
+	
+	(clone at: #config) at: #color put: 'blue'.
+	
+	self assert: (original atPath: #(config color)) equals: 'red'.
+	self assert: (clone atPath: #(config color)) equals: 'blue'.
+	
+	self deny: (original at: #config) == (clone at: #config).
+]
+
 { #category : 'tests' }
 CTKeyedTreeTest >> testDepth [
 

src/Containers-KeyedTree/CTKeyedTree.class.st

@@ -268,21 +268,6 @@ CTKeyedTree >> collect: aBlock [
 	^ result
 ]
 
-{ #category : 'copying' }
-CTKeyedTree >> copy [
-
-		"Answer a deep copy of the receiver including all subtrees."
-	
-	| result |
-	result := self species new.
-	self keysAndValuesDo: [ :key :value |
-		result at: key put: (
-			(value isKindOf: self class)
-				ifTrue: [ value copy ]
-				ifFalse: [ value ] ) ].
-	^ result
-]
-
 { #category : 'accessing' }
 CTKeyedTree >> depth [
 
@@ -496,16 +481,10 @@ CTKeyedTree >> pathsAndValuesDo: aBlock currentPath: pathArray [
 
 { #category : 'copying' }
 CTKeyedTree >> postCopy [
-
-	"Ensure proper deep copying of associations and subtrees."
 
-	array := array collect: [ :assoc |
-		assoc ifNotNil: [ 
-			Association
-				key: assoc key
-				value: ((assoc value isKindOf: self class)
-					ifTrue: [ assoc value copy ]
-					ifFalse: [ assoc value ]) ] ]
+	super postCopy.
+	self keysAndValuesDo: [ :key :value |
+		self at: key put: value copy ]
 ]
 
 { #category : 'printing' }