Improved tests [skip ci]

Author: ankane

test/pqxx_test.cpp

@@ -144,7 +144,7 @@ void test_vector_to_string() {
     assert_equal(pqxx::to_string(pgvector::Vector({-1.234567890123})), "[-1.2345679]");
 
     assert_exception<pqxx::conversion_overrun>([] {
-        auto unused = pqxx::to_string(pgvector::Vector(std::vector<float>(16001)));
+        pqxx::to_string(pgvector::Vector(std::vector<float>(16001)));
     }, "vector cannot have more than 16000 dimensions");
 }
 
@@ -182,7 +182,7 @@ void test_halfvec_to_string() {
     assert_equal(pqxx::to_string(pgvector::HalfVector({-1.234567890123})), "[-1.2345679]");
 
     assert_exception<pqxx::conversion_overrun>([] {
-        auto unused = pqxx::to_string(pgvector::HalfVector(std::vector<float>(16001)));
+        pqxx::to_string(pgvector::HalfVector(std::vector<float>(16001)));
     }, "halfvec cannot have more than 16000 dimensions");
 }
 
@@ -219,6 +219,10 @@ void test_sparsevec_to_string() {
     assert_equal(pqxx::to_string(pgvector::SparseVector({1, 0, 2, 0, 3, 0})), "{1:1,3:2,5:3}/6");
     std::unordered_map<int, float> map = {{999999999, -1.234567890123}};
     assert_equal(pqxx::to_string(pgvector::SparseVector(map, 1000000000)), "{1000000000:-1.2345679}/1000000000");
+
+    assert_exception<pqxx::conversion_overrun>([] {
+        pqxx::to_string(pgvector::SparseVector(std::vector<float>(16001, 1)));
+    }, "sparsevec cannot have more than 16000 dimensions");
 }
 
 void test_sparsevec_from_string() {
@@ -272,10 +276,6 @@ void test_sparsevec_from_string() {
     assert_exception<pqxx::conversion_error>([] {
         auto unused = pqxx::from_string<pgvector::SparseVector>("{}/a");
     }, "Could not convert 'a' to int: Invalid argument.");
-
-    assert_exception<pqxx::conversion_overrun>([] {
-        auto unused = pqxx::to_string(pgvector::SparseVector(std::vector<float>(16001, 1)));
-    }, "sparsevec cannot have more than 16000 dimensions");
 }
 
 void test_pqxx() {

test/sparsevec_test.cpp

@@ -27,11 +27,11 @@ static void test_constructor_map() {
     assert_equal(vec.values() == std::vector<float>{1, 2, 3}, true);
 
     assert_exception<std::invalid_argument>([&]{
-        auto unused = SparseVector(map, 0);
+        SparseVector(map, 0);
     }, "sparsevec must have at least 1 dimension");
 
     assert_exception<std::invalid_argument>([&]{
-        auto unused = SparseVector(map, 4);
+        SparseVector(map, 4);
     }, "sparsevec index out of bounds");
 }