return client_secret in the registration

Author: ylebre

solid/lib/Controller/ServerController.php

@@ -343,10 +343,11 @@ public function register() {
 			$origin .= ":" . $parsedOrigin['port'];
 		}
 
-		$clientId = $this->config->saveClientRegistration($origin, $clientData);
+		$clientData = $this->config->saveClientRegistration($origin, $clientData);
 		$registration = array(
-			'client_id' => $clientId,
-			'registration_client_uri' => $this->urlGenerator->getAbsoluteURL($this->urlGenerator->linkToRoute("solid.server.registeredClient", array("clientId" => $clientId))),
+			'client_id' => $clientData['client_id'],
+			'client_secret' => $clientData['client_secret'],
+			'registration_client_uri' => $this->urlGenerator->getAbsoluteURL($this->urlGenerator->linkToRoute("solid.server.registeredClient", array("clientId" => $clientData['client_id']))),
 			'client_id_issued_at' => $clientData['client_id_issued_at'],
 			'redirect_uris' => $clientData['redirect_uris'],
 		);
@@ -413,7 +414,7 @@ private function getClient($clientId) {
 		if ($clientId && count($clientRegistration)) {
 			return new \Pdsinterop\Solid\Auth\Config\Client(
 				$clientId,
-				$clientRegistration['client_secret'],
+				$clientRegistration['client_secret'] ?? '',
 				$clientRegistration['redirect_uris'],
 				$clientRegistration['client_name']
 			);

solid/lib/ServerConfig.php

@@ -126,12 +126,13 @@ public function saveClientRegistration($origin, $clientData) {
 				$clientData['redirect_uris'] = array_unique($clientData['redirect_uris']);
 			}
 
+			$clientData['client_id'] = $originHash;
 			$clientData['client_name'] = $origin;
 			$clientData['client_secret'] = md5(random_bytes(32));
 			$this->config->setAppValue('solid', "client-" . $originHash, json_encode($clientData));
 
 			$this->config->setAppValue('solid', "client-" . $origin, json_encode($clientData));
-			return $originHash;
+			return $clientData;
 		}
 
 		public function removeClientRegistration($clientId) {