Change StorageUrlTrait::getStorageUrl() method to be public.

Author: Potherca

solid/lib/Controller/GetStorageUrlTrait.php

@@ -30,7 +30,7 @@ final public function setUrlGenerator(IURLGenerator $urlGenerator): void
 	 * @FIXME: Add check for bob.nextcloud.local/solid/alice to throw 404
 	 * @TODO: Use route without `@alice` in /apps/solid/@alice/profile/card#me when user-domains are enabled
 	 */
-	protected function getStorageUrl($userId) {
+	public function getStorageUrl($userId) {
 		$routeUrl = $this->urlGenerator->linkToRoute(
 			'solid.storage.handleHead',
 			['userId' => $userId, 'path' => 'foo']

solid/tests/Unit/Controller/GetStorageUrlTraitTest.php

@@ -27,16 +27,6 @@ protected function setUp(): void
 	{
 		$this->trait = new class {
 			use GetStorageUrlTrait;
-
-			public function _getStorageUrl($userId)
-			{
-				$class = new ReflectionObject($this);
-				$method = $class->getMethod('getStorageUrl');
-				// Only needed for PHP 8.1 and lower
-				$method->setAccessible(true);
-
-				return $method->invokeArgs($this, [$userId]);
-			}
 		};
 	}
 
@@ -51,7 +41,7 @@ public function testGetStorageUrlWithoutUrlGenerator()
 		$this->expectException(Error::class);
 		$this->expectExceptionMessage('urlGenerator must not be accessed before initialization');
 
-		$this->trait->_getStorageUrl(self::MOCK_USER_ID);
+		$this->trait->getStorageUrl(self::MOCK_USER_ID);
 	}
 
 	/**
@@ -67,7 +57,7 @@ public function testGetStorageUrlWithoutConfig()
 
 		$this->trait->setUrlGenerator($mockUrlGenerator);
 
-		$this->trait->_getStorageUrl(self::MOCK_USER_ID);
+		$this->trait->getStorageUrl(self::MOCK_USER_ID);
 	}
 
 	/**
@@ -83,7 +73,7 @@ public function testGetStorageUrlWithUserSubDomainsDisabled($url, $userId, $expe
 		$this->trait->setUrlGenerator($mockUrlGenerator);
 		$this->trait->setConfig($mockConfig);
 
-		$actual = $this->trait->_getStorageUrl($userId);
+		$actual = $this->trait->getStorageUrl($userId);
 
 		$this->assertEquals($expected, $actual);
 	}
@@ -103,7 +93,7 @@ public function testGetStorageUrlWithUserSubDomainsEnabled($url, $userId, $expec
 		$this->trait->setUrlGenerator($mockUrlGenerator);
 		$this->trait->setConfig($mockConfig);
 
-		$actual = $this->trait->_getStorageUrl($userId);
+		$actual = $this->trait->getStorageUrl($userId);
 
 		$this->assertEquals($expected, $actual);
 	}