Skip to content

Commit b05fb0e

Browse files
committed
fix for sending multiple headers with the same value
1 parent 063123d commit b05fb0e

4 files changed

Lines changed: 6 additions & 13 deletions

File tree

solid/lib/Controller/CalendarController.php

Lines changed: 1 addition & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -235,9 +235,7 @@ private function respond($response) {
235235
$result = new PlainResponse($body);
236236

237237
foreach ($headers as $header => $values) {
238-
foreach ($values as $value) {
239-
$result->addHeader($header, $value);
240-
}
238+
$result->addHeader($header, implode(", ", $values));
241239
}
242240

243241
$result->setStatus($statusCode);

solid/lib/Controller/ContactsController.php

Lines changed: 2 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -236,11 +236,9 @@ private function respond($response) {
236236
$result = new PlainResponse($body);
237237

238238
foreach ($headers as $header => $values) {
239-
foreach ($values as $value) {
240-
$result->addHeader($header, $value);
241-
}
239+
$result->addHeader($header, implode(", ", $values));
242240
}
243-
241+
244242
$result->setStatus($statusCode);
245243
return $result;
246244
}

solid/lib/Controller/ProfileController.php

Lines changed: 1 addition & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -256,9 +256,7 @@ private function respond($response) {
256256
$result = new PlainResponse($body);
257257

258258
foreach ($headers as $header => $values) {
259-
foreach ($values as $value) {
260-
$result->addHeader($header, $value);
261-
}
259+
$result->addHeader($header, implode(", ", $values));
262260
}
263261
// $origin = $_SERVER['HTTP_ORIGIN'] ?? "*";
264262
// $result->addHeader('Access-Control-Allow-Credentials', 'true');

solid/lib/Controller/StorageController.php

Lines changed: 2 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -399,10 +399,9 @@ private function respond($response) {
399399
$result = new PlainResponse($body);
400400

401401
foreach ($headers as $header => $values) {
402-
foreach ($values as $value) {
403-
$result->addHeader($header, $value);
404-
}
402+
$result->addHeader($header, implode(", ", $values));
405403
}
404+
406405
// $origin = $_SERVER['HTTP_ORIGIN'];
407406
// $result->addHeader('Access-Control-Allow-Credentials', 'true');
408407
// $result->addHeader('Access-Control-Allow-Headers', 'Content-Type, Authorization');

0 commit comments

Comments
 (0)