Skip to content

Commit a5aae60

Browse files
committed
Change workflow to use commit hash as docker tag.
1 parent ccb287d commit a5aae60

1 file changed

Lines changed: 5 additions & 6 deletions

File tree

.github/workflows/ci.yml

Lines changed: 5 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -28,11 +28,10 @@ jobs:
2828
username: ${{ github.actor }}
2929
password: ${{ secrets.GITHUB_TOKEN }}
3030

31-
# @FIXME: In stead of `latest` docker images need to be tagged with the MR/PR reference (or commit hash)
3231
- name: Build Solid-Nextcloud Docker image
3332
run: |
34-
docker build -t "ghcr.io/pdsinterop/solid-nextcloud:latest" .
35-
docker push "ghcr.io/pdsinterop/solid-nextcloud:latest"
33+
docker build -t "ghcr.io/pdsinterop/solid-nextcloud:${{ github.sha }}" .
34+
docker push "ghcr.io/pdsinterop/solid-nextcloud:${{ github.sha }}"
3635
3736
solid-testsuite:
3837
strategy:
@@ -61,7 +60,7 @@ jobs:
6160
run: |
6261
docker pull michielbdejong/nextcloud-cookie
6362
docker pull ${{ matrix.test }}
64-
docker pull ghcr.io/pdsinterop/solid-nextcloud:latest
63+
docker pull ghcr.io/pdsinterop/solid-nextcloud:${{ github.sha }}
6564
docker pull ghcr.io/pdsinterop/php-solid-pubsub-server:latest
6665
6766
- name: Start Docker Containers
@@ -70,8 +69,8 @@ jobs:
7069
docker run -i --network=testnet -d --name 'pubsub' "ghcr.io/pdsinterop/php-solid-pubsub-server:latest"
7170
7271
source ./run-solid-test-suite.sh
73-
startSolidNextcloud 'server' "ghcr.io/pdsinterop/solid-nextcloud:latest" ${{ matrix.test }}
74-
startSolidNextcloud 'thirdparty' "ghcr.io/pdsinterop/solid-nextcloud:latest" ${{ matrix.test }}
72+
startSolidNextcloud 'server' "ghcr.io/pdsinterop/solid-nextcloud:${{ github.sha }}" ${{ matrix.test }}
73+
startSolidNextcloud 'thirdparty' "ghcr.io/pdsinterop/solid-nextcloud:${{ github.sha }}" ${{ matrix.test }}
7574
7675
echo "COOKIE_server=${COOKIE_server}" >> "${GITHUB_ENV}"
7776
echo "COOKIE_thirdparty=${COOKIE_thirdparty}" >> "${GITHUB_ENV}"

0 commit comments

Comments
 (0)