only generate the secret once to make it stable

ylebre · ylebre · commit 9f0f5471a786 · 2025-01-31T11:11:26.000+01:00
diff --git a/solid/lib/BaseServerConfig.php b/solid/lib/BaseServerConfig.php
@@ -161,9 +161,10 @@ public function saveClientRegistration($origin, $clientData) {
 				}
 				$clientData['redirect_uris'] = array_unique($clientData['redirect_uris']);
 			}
-
+			if (!$existingRegistration) {
+				$clientData['client_secret'] = md5(random_bytes(32));
+			}
 			$clientData['client_name'] = $origin;
-			$clientData['client_secret'] = md5(random_bytes(32));
 			$this->config->setAppValue('solid', "client-" . $originHash, json_encode($clientData));
 			$this->config->setAppValue('solid', "client-" . $origin, json_encode($clientData));
 			$this->saveClientConfig($originHash, $clientData);

Original file line number	Diff line number	Diff line change
`@@ -161,9 +161,10 @@ public function saveClientRegistration($origin, $clientData) {`
`161`	`161`	`}`
`162`	`162`	`$clientData['redirect_uris'] = array_unique($clientData['redirect_uris']);`
`163`	`163`	`}`
`164`		`-`
	`164`	`+ if (!$existingRegistration) {`
	`165`	`+ $clientData['client_secret'] = md5(random_bytes(32));`
	`166`	`+ }`
`165`	`167`	`$clientData['client_name'] = $origin;`
`166`		`- $clientData['client_secret'] = md5(random_bytes(32));`
`167`	`168`	`$this->config->setAppValue('solid', "client-" . $originHash, json_encode($clientData));`
`168`	`169`	`$this->config->setAppValue('solid', "client-" . $origin, json_encode($clientData));`
`169`	`170`	`$this->saveClientConfig($originHash, $clientData);`