Add logic to cast mixed AppValue to boolean.

Author: Potherca

solid/lib/BaseServerConfig.php

@@ -1,14 +1,19 @@
 <?php
 	namespace OCA\Solid;
 
+	use InvalidArgumentException;
 	use OCP\IConfig;
 
 	class BaseServerConfig {
+
+		////////////////////////////// CLASS PROPERTIES \\\\\\\\\\\\\\\\\\\\\\\\\\\\
+
+		public const ERROR_INVALID_ARGUMENT = 'Invalid %s for %s: %s. Must be one of %s.';
+
 		protected IConfig $config;
 
-		/**
-		 * @param IConfig $config
-		 */
+		//////////////////////////////// PUBLIC API \\\\\\\\\\\\\\\\\\\\\\\\\\\\\\\\
+
 		public function __construct(IConfig $config) {
 			$this->config = $config;
 		}
@@ -152,6 +157,7 @@ public function removeClientConfig($clientId) {
 			unset($scopes[$clientId]);
 			$this->config->setAppValue('solid', 'clientScopes', $scopes);
 		}
+
 		public function saveClientRegistration($origin, $clientData) {
 			$originHash = md5($origin);
 			$existingRegistration = $this->getClientRegistration($originHash);
@@ -183,11 +189,56 @@ public function getClientRegistration($clientId) {
 			return json_decode($data, true);
 		}
 
-		public function getUserSubDomainsEnabled(): bool {
-			return $this->config->getAppValue('solid', 'userSubDomainsEnabled', false);
+		public function getUserSubDomainsEnabled() {
+			$value = $this->config->getAppValue('solid', 'userSubDomainsEnabled', false);
+
+			return $this->castToBool($value);
 		}
 
-		public function setUserSubDomainsEnabled(bool $enabled) {
-			$this->config->setAppValue('solid', 'userSubDomainsEnabled', $enabled);
+		public function setUserSubDomainsEnabled($enabled) {
+			$value = $this->castToBool($enabled);
+
+			$this->config->setAppValue('solid', 'userSubDomainsEnabled', $value);
+		}
+
+		////////////////////////////// UTILITY METHODS \\\\\\\\\\\\\\\\\\\\\\\\\\\\\
+
+		private function castToBool(string $mixedValue): bool
+		{
+			$type = gettype($mixedValue);
+
+			if ($type === 'boolean' || $type === 'NULL' || $type === 'integer') {
+				$value = (bool) $mixedValue;
+			} else {
+				if ($type === 'string') {
+					$mixedValue = strtolower($mixedValue);
+					if ($mixedValue === 'true' || $mixedValue === '1') {
+						$value = true;
+					} elseif ($mixedValue === 'false' || $mixedValue === '0') {
+						$value = false;
+					} else {
+						$error = [
+							'invalid' => 'value',
+							'for' => 'userSubDomainsEnabled',
+							'received' => $mixedValue,
+							'expected' => implode(',', ['true', 'false', '1', '0'])
+						];
+					}
+				} else {
+					$error = [
+						'invalid' => 'type',
+						'for' => 'userSubDomainsEnabled',
+						'received' => $type,
+						'expected' => implode(',', ['boolean', 'NULL', 'integer', 'string'])
+					];
+				}
+			}
+
+			if (isset($error)) {
+				$errorMessage = vsprintf(self::ERROR_INVALID_ARGUMENT, $error);
+				throw new InvalidArgumentException($errorMessage);
+			}
+
+			return $value;
 		}
 	}