Skip to content

Commit 7162a2c

Browse files
Run latest version of solid-crud-tests (#103)
* Use DpopFactoryTrait * Use solid-crud-tests v7.0.5
1 parent 59e9dda commit 7162a2c

2 files changed

Lines changed: 21 additions & 5 deletions

File tree

run-solid-test-suite.sh

Lines changed: 3 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -8,8 +8,8 @@ function setup {
88
docker pull michielbdejong/nextcloud-cookie
99
docker pull solidtestsuite/webid-provider-tests:v2.1.0
1010
docker tag solidtestsuite/webid-provider-tests:v2.1.0 webid-provider-tests
11-
docker pull solidtestsuite/solid-crud-tests:v6.0.0
12-
docker tag solidtestsuite/solid-crud-tests:v6.0.0 solid-crud-tests
11+
docker pull solidtestsuite/solid-crud-tests:v7.0.5
12+
docker tag solidtestsuite/solid-crud-tests:v7.0.5 solid-crud-tests
1313
docker pull solidtestsuite/web-access-control-tests:v7.1.0
1414
docker tag solidtestsuite/web-access-control-tests:v7.1.0 web-access-control-tests
1515
}
@@ -44,6 +44,7 @@ function startSolidNextcloud {
4444
function runTests {
4545
echo "Running $1 tests against server with cookie $COOKIE_server"
4646
docker run --rm --network=testnet \
47+
--name tester \
4748
--env COOKIE="$COOKIE_server" \
4849
--env COOKIE_ALICE="$COOKIE_server" \
4950
--env COOKIE_BOB="$COOKIE_thirdparty" \

solid/lib/Controller/SolidWebhookController.php

Lines changed: 18 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -8,13 +8,15 @@
88
use OCA\Solid\ServerConfig;
99
use OCA\Solid\PlainResponse;
1010
use OCA\Solid\Notifications\SolidNotifications;
11+
use OCA\Solid\DpopFactoryTrait;
1112

1213
use OCP\AppFramework\Controller;
1314
use OCP\AppFramework\Http\DataResponse;
1415
use OCP\IRequest;
1516
use OCP\IUserManager;
1617
use OCP\IURLGenerator;
1718
use OCP\ISession;
19+
use OCP\IDBConnection;
1820
use OCP\IConfig;
1921
use OCP\Files\IRootFolder;
2022
use OCP\Files\IHomeStorage;
@@ -29,6 +31,8 @@
2931
use Pdsinterop\Solid\Auth\WAC as WAC;
3032

3133
class SolidWebhookController extends Controller {
34+
use DpopFactoryTrait;
35+
3236
/* @var IURLGenerator */
3337
private $urlGenerator;
3438

@@ -38,8 +42,18 @@ class SolidWebhookController extends Controller {
3842
/** @var SolidWebhookService */
3943
private $webhookService;
4044

41-
public function __construct($AppName, IRootFolder $rootFolder, IRequest $request, ISession $session, IUserManager $userManager, IURLGenerator $urlGenerator, $userId, IConfig $config, SolidWebhookService $webhookService)
42-
{
45+
public function __construct(
46+
$AppName,
47+
IRootFolder $rootFolder,
48+
IRequest $request,
49+
ISession $session,
50+
IUserManager $userManager,
51+
IURLGenerator $urlGenerator,
52+
$userId,
53+
IConfig $config,
54+
SolidWebhookService $webhookService,
55+
IDBConnection $connection,
56+
) {
4357
parent::__construct($AppName, $request);
4458
require_once(__DIR__.'/../../vendor/autoload.php');
4559
$this->config = new \OCA\Solid\ServerConfig($config, $urlGenerator, $userManager);
@@ -49,7 +63,8 @@ public function __construct($AppName, IRootFolder $rootFolder, IRequest $request
4963
$this->session = $session;
5064
$this->webhookService = $webhookService;
5165

52-
$this->DPop = new DPop();
66+
$this->setJtiStorage($connection);
67+
$this->DPop = $this->getDpop();
5368
try {
5469
$this->rawRequest = \Laminas\Diactoros\ServerRequestFactory::fromGlobals($_SERVER, $_GET, $_POST, $_COOKIE, $_FILES);
5570
$this->webId = $this->DPop->getWebId($this->rawRequest);

0 commit comments

Comments
 (0)