Skip to content

Commit 6d5bfcd

Browse files
committed
remove client_secret for now
1 parent bb2ceeb commit 6d5bfcd

1 file changed

Lines changed: 8 additions & 1 deletion

File tree

solid/lib/Controller/ServerController.php

Lines changed: 8 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -346,7 +346,14 @@ public function register() {
346346
$clientData = $this->config->saveClientRegistration($origin, $clientData);
347347
$registration = array(
348348
'client_id' => $clientData['client_id'],
349-
'client_secret' => $clientData['client_secret'],
349+
/*
350+
FIXME: returning client_secret will trigger calls with basic auth to us. To get this to work, we need this patch:
351+
// File /var/www/vhosts/solid-nextcloud/site/www/lib/base.php not changed so no update needed
352+
// ($request->getRawPathInfo() !== '/apps/oauth2/api/v1/token') &&
353+
// ($request->getRawPathInfo() !== '/apps/solid/token')
354+
*/
355+
// 'client_secret' => $clientData['client_secret'], // FIXME: Returning this means we need to patch Nextcloud to accept tokens on calls to
356+
350357
'registration_client_uri' => $this->urlGenerator->getAbsoluteURL($this->urlGenerator->linkToRoute("solid.server.registeredClient", array("clientId" => $clientData['client_id']))),
351358
'client_id_issued_at' => $clientData['client_id_issued_at'],
352359
'redirect_uris' => $clientData['redirect_uris'],

0 commit comments

Comments
 (0)