Skip to content

Commit dfde5ea

Browse files
committed
Add TODO markers for various concerns.
1 parent 9fa3f7c commit dfde5ea

1 file changed

Lines changed: 5 additions & 0 deletions

File tree

src/Server.php

Lines changed: 5 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -98,6 +98,7 @@ final public function __construct(Filesystem $filesystem, Response $response, Gr
9898
$this->filesystem = $filesystem;
9999
$this->graph = $graph ?? new Graph();
100100
$this->response = $response;
101+
// @TODO: Mention \EasyRdf_Namespace::set('lm', 'https://purl.org/pdsinterop/link-metadata#');
101102
}
102103

103104
final public function respondToRequest(Request $request): Response
@@ -280,6 +281,7 @@ private function handleSparqlUpdate(Response $response, string $path, $contents)
280281

281282
try {
282283
// Assuming this is in our native format, turtle
284+
// @CHECKME: Does the Graph Parse here also need an URI?
283285
$graph->parse($data, "turtle");
284286
// FIXME: Adding this base will allow us to parse <> entries; , $this->baseUrl . $this->basePath . $path), but that breaks the build.
285287
// FIXME: Use enums from namespace Pdsinterop\Rdf\Enum\Format instead of 'turtle'?
@@ -294,12 +296,14 @@ private function handleSparqlUpdate(Response $response, string $path, $contents)
294296
switch($command) {
295297
case "INSERT":
296298
// insert $triple(s) into $graph
299+
// @CHECKME: Does the Graph Parse here also need an URI?
297300
$graph->parse($triples, "turtle"); // FIXME: The triples here are in sparql format, not in turtle;
298301

299302
break;
300303
case "DELETE":
301304
// delete $triples from $graph
302305
$deleteGraph = $this->getGraph();
306+
// @CHECKME: Does the Graph Parse here also need an URI?
303307
$deleteGraph->parse($triples, "turtle"); // FIXME: The triples here are in sparql format, not in turtle;
304308
$resources = $deleteGraph->resources();
305309
foreach ($resources as $resource) {
@@ -701,6 +705,7 @@ private function addLinkRelationHeaders(Response $response, string $path, $mime=
701705
{
702706
// @FIXME: If a `.meta` file is requested, it must have header `Link: </path/to/resource>; rel="describes"`
703707

708+
//@CHECKME: Should the ACL link header be added here or in/by the Auth server?
704709
if ($this->hasAcl($path, $mime)) {
705710
$value = sprintf('<%s>; rel="acl"', $this->getAclPath($path, $mime));
706711
$response = $response->withAddedHeader('Link', $value);

0 commit comments

Comments
 (0)