Skip to content

Commit dde938f

Browse files
committed
Change --optimize from bool to double
Updates pcb2gcodeGUI to work with latest pcb2gcode(v2.1.0) Signed-off-by: Michael Brown <producer@holotronic.dk>
1 parent f073ac0 commit dde938f

2 files changed

Lines changed: 39 additions & 12 deletions

File tree

mainwindow.cpp

Lines changed: 3 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -80,7 +80,7 @@ MainWindow::MainWindow(QWidget *parent) :
8080
args[ COMMONARGS ].insert("vectorial", ui->vectorialCheckBox);
8181
args[ COMMONARGS ].insert("nog64", ui->nog64CheckBox);
8282
args[ COMMONARGS ].insert("tolerance", ui->toleranceDoubleSpinBox);
83-
args[ COMMONARGS ].insert("optimise", ui->optimiseCheckBox);
83+
args[ COMMONARGS ].insert("optimise", ui->optimiseDoubleSpinBox);
8484
args[ COMMONARGS ].insert("zero-start", ui->zerostartCheckBox);
8585
args[ COMMONARGS ].insert("dpi", ui->dpiSpinBox);
8686
args[ COMMONARGS ].insert("tile-x", ui->tilexSpinBox);
@@ -153,7 +153,6 @@ MainWindow::MainWindow(QWidget *parent) :
153153
connect(ui->vectorialCheckBox, SIGNAL(toggled(bool)), ui->voronoiCheckBox, SLOT(setEnabled(bool)));
154154
connect(ui->voronoiCheckBox, SIGNAL(toggled(bool)), this, SLOT(voronoiEnable(bool)));
155155
connect(ui->filloutlineCheckBox, SIGNAL(toggled(bool)), this, SLOT(fillOutlineEnable(bool)));
156-
connect(ui->optimiseCheckBox, SIGNAL(toggled(bool)), this, SLOT(bridgesAvailable()));
157156
connect(ui->milldrillCheckBox, SIGNAL(toggled(bool)), ui->milldrilldiameterDoubleSpinBox, SLOT(setEnabled(bool)));
158157
connect(ui->softwareComboBox, SIGNAL(currentTextChanged(QString)), this, SLOT(updateAlCustomEnableState(QString)));
159158

@@ -270,7 +269,7 @@ void MainWindow::fillOutlineEnable(bool enable)
270269

271270
void MainWindow::bridgesAvailable()
272271
{
273-
bool bridgesEnabled = ui->vectorialCheckBox->isChecked() || ui->optimiseCheckBox->isChecked();
272+
bool bridgesEnabled = ui->vectorialCheckBox->isChecked();
274273

275274
ui->bridgesDoubleSpinBox->setEnabled(bridgesEnabled);
276275
ui->zbridgesDoubleSpinBox->setEnabled(bridgesEnabled);
@@ -493,7 +492,7 @@ void MainWindow::changeMetricInputUnits(bool metric)
493492
ui->zdrillDoubleSpinBox, ui->zchangeDoubleSpinBox, ui->cutterdiameterDoubleSpinBox,
494493
ui->zcutDoubleSpinBox, ui->cutinfeedDoubleSpinBox, ui->outlinewidthDoubleSpinBox,
495494
ui->bridgesDoubleSpinBox, ui->zbridgesDoubleSpinBox, ui->alxDoubleSpinBox,
496-
ui->alyDoubleSpinBox, ui->toleranceDoubleSpinBox };
495+
ui->alyDoubleSpinBox, ui->toleranceDoubleSpinBox, ui->optimiseDoubleSpinBox };
497496

498497
QSpinBox *spinBoxes[] = { ui->millfeedSpinBox, ui->drillfeedSpinBox, ui->cutfeedSpinBox, ui->alprobefeedSpinBox };
499498

mainwindow.ui

Lines changed: 36 additions & 8 deletions
Original file line numberDiff line numberDiff line change
@@ -43,7 +43,7 @@
4343
<property name="minimumSize">
4444
<size>
4545
<width>545</width>
46-
<height>485</height>
46+
<height>500</height>
4747
</size>
4848
</property>
4949
<property name="toolTip">
@@ -408,6 +408,19 @@
408408
</property>
409409
</widget>
410410
</item>
411+
<item row="8" column="0">
412+
<widget class="QLabel" name="optimiseLabel">
413+
<property name="toolTip">
414+
<string>&lt;html&gt;&lt;head/&gt;&lt;body&gt;&lt;p&gt;&lt;span style=&quot; font-style:italic;&quot;&gt;--optimise&lt;/span&gt;&lt;/p&gt;&lt;p&gt;optimise output gcode, reducing its output size up to 95%, while accepting a very little loss of precision&lt;/p&gt;&lt;/body&gt;&lt;/html&gt;</string>
415+
</property>
416+
<property name="text">
417+
<string>optimise val</string>
418+
</property>
419+
<property name="buddy">
420+
<cstring>optimiseDoubleSpinBox</cstring>
421+
</property>
422+
</widget>
423+
</item>
411424
<item row="2" column="1">
412425
<widget class="QDoubleSpinBox" name="zsafeDoubleSpinBox">
413426
<property name="toolTip">
@@ -481,16 +494,31 @@
481494
</property>
482495
</widget>
483496
</item>
484-
<item row="8" column="0">
485-
<widget class="QCheckBox" name="optimiseCheckBox">
497+
<item row="8" column="1">
498+
<widget class="QDoubleSpinBox" name="optimiseDoubleSpinBox">
499+
<property name="enabled">
500+
<bool>true</bool>
501+
</property>
486502
<property name="toolTip">
487503
<string>&lt;html&gt;&lt;head/&gt;&lt;body&gt;&lt;p&gt;&lt;span style=&quot; font-style:italic;&quot;&gt;--optimise&lt;/span&gt;&lt;/p&gt;&lt;p&gt;optimise output gcode, reducing its output size up to 95%, while accepting a very little loss of precision&lt;/p&gt;&lt;/body&gt;&lt;/html&gt;</string>
488504
</property>
489-
<property name="text">
490-
<string>Optimise toolpaths</string>
505+
<property name="suffix">
506+
<string> in</string>
491507
</property>
492-
<property name="checked">
493-
<bool>true</bool>
508+
<property name="decimals">
509+
<number>5</number>
510+
</property>
511+
<property name="minimum">
512+
<double>0.000010000000000</double>
513+
</property>
514+
<property name="maximum">
515+
<double>1.000000000000000</double>
516+
</property>
517+
<property name="singleStep">
518+
<double>0.000010000000000</double>
519+
</property>
520+
<property name="value">
521+
<double>0.000½00000000000</double>
494522
</property>
495523
</widget>
496524
</item>
@@ -2246,7 +2274,7 @@
22462274
<tabstop>vectorialCheckBox</tabstop>
22472275
<tabstop>nog64CheckBox</tabstop>
22482276
<tabstop>toleranceDoubleSpinBox</tabstop>
2249-
<tabstop>optimiseCheckBox</tabstop>
2277+
<tabstop>optimiseDoubleSpinBox</tabstop>
22502278
<tabstop>zerostartCheckBox</tabstop>
22512279
<tabstop>dpiSpinBox</tabstop>
22522280
<tabstop>tilexSpinBox</tabstop>

0 commit comments

Comments
 (0)