Skip to content

Commit b7c2a90

Browse files
committed
reorder items in OutlineTab chronology
and change obsoleted --outline-width to --cut-vertfeed Signed-off-by: Michael Brown <producer@holotronic.dk>
1 parent 8d8a2ab commit b7c2a90

3 files changed

Lines changed: 176 additions & 191 deletions

File tree

mainwindow.cpp

Lines changed: 4 additions & 15 deletions
Original file line numberDiff line numberDiff line change
@@ -108,7 +108,7 @@ MainWindow::MainWindow(QWidget *parent) :
108108
args[ OUTLINEARGS ].insert("cut-feed", ui->cutfeedSpinBox);
109109
args[ OUTLINEARGS ].insert("cut-speed", ui->cutspeedSpinBox);
110110
args[ OUTLINEARGS ].insert("cut-infeed", ui->cutinfeedDoubleSpinBox);
111-
args[ OUTLINEARGS ].insert("outline-width", ui->outlinewidthDoubleSpinBox);
111+
args[ OUTLINEARGS ].insert("cut-vertfeed", ui->cutvertfeedSpinBox);
112112
args[ OUTLINEARGS ].insert("bridges", ui->bridgesDoubleSpinBox);
113113
args[ OUTLINEARGS ].insert("zbridges", ui->zbridgesDoubleSpinBox);
114114
args[ OUTLINEARGS ].insert("bridgesnum", ui->bridgesnumSpinBox);
@@ -152,7 +152,6 @@ MainWindow::MainWindow(QWidget *parent) :
152152
connect(ui->vectorialCheckBox, SIGNAL(toggled(bool)), this, SLOT(bridgesAvailable()));
153153
connect(ui->vectorialCheckBox, SIGNAL(toggled(bool)), ui->voronoiCheckBox, SLOT(setEnabled(bool)));
154154
connect(ui->voronoiCheckBox, SIGNAL(toggled(bool)), this, SLOT(voronoiEnable(bool)));
155-
connect(ui->filloutlineCheckBox, SIGNAL(toggled(bool)), this, SLOT(fillOutlineEnable(bool)));
156155
connect(ui->milldrillCheckBox, SIGNAL(toggled(bool)), ui->milldrilldiameterDoubleSpinBox, SLOT(setEnabled(bool)));
157156
connect(ui->softwareComboBox, SIGNAL(currentTextChanged(QString)), this, SLOT(updateAlCustomEnableState(QString)));
158157

@@ -195,6 +194,7 @@ MainWindow::MainWindow(QWidget *parent) :
195194
ui->loadingLabel->setMovie(&loadingIcon);
196195
ui->loadingLabel->hide();
197196
ui->mirroraxisDoubleSpinBox->setEnabled(true);
197+
ui->cutvertfeedSpinBox->setEnabled(true);
198198
}
199199

200200
void MainWindow::checkPcb2gcodeVersion()
@@ -242,14 +242,9 @@ void MainWindow::vectorialEnable(bool enable)
242242
{
243243
if (ui->voronoiCheckBox->isChecked())
244244
ui->extrapassesSpinBox->setEnabled(false);
245-
246-
ui->outlinewidthDoubleSpinBox->setEnabled(false);
247245
}
248246
else
249247
{
250-
if (ui->filloutlineCheckBox->isChecked())
251-
ui->outlinewidthDoubleSpinBox->setEnabled(true);
252-
253248
ui->extrapassesSpinBox->setEnabled(true);
254249
}
255250
}
@@ -260,12 +255,6 @@ void MainWindow::voronoiEnable(bool enable)
260255
ui->offsetDoubleSpinBox->setEnabled(!enable);
261256
}
262257

263-
void MainWindow::fillOutlineEnable(bool enable)
264-
{
265-
if (!ui->vectorialCheckBox->isChecked())
266-
ui->outlinewidthDoubleSpinBox->setEnabled(enable);
267-
}
268-
269258
void MainWindow::bridgesAvailable()
270259
{
271260
bool bridgesEnabled = ui->vectorialCheckBox->isChecked();
@@ -489,12 +478,12 @@ void MainWindow::changeMetricInputUnits(bool metric)
489478
{
490479
QDoubleSpinBox *doubleSpinBoxes[] = { ui->zworkDoubleSpinBox, ui->zsafeDoubleSpinBox, ui->offsetDoubleSpinBox,
491480
ui->zdrillDoubleSpinBox, ui->zchangeDoubleSpinBox, ui->cutterdiameterDoubleSpinBox,
492-
ui->zcutDoubleSpinBox, ui->cutinfeedDoubleSpinBox, ui->outlinewidthDoubleSpinBox,
481+
ui->zcutDoubleSpinBox, ui->cutinfeedDoubleSpinBox,
493482
ui->bridgesDoubleSpinBox, ui->zbridgesDoubleSpinBox, ui->alxDoubleSpinBox,
494483
ui->alyDoubleSpinBox, ui->toleranceDoubleSpinBox, ui->optimiseDoubleSpinBox,
495484
ui->mirroraxisDoubleSpinBox };
496485

497-
QSpinBox *spinBoxes[] = { ui->millfeedSpinBox, ui->drillfeedSpinBox, ui->cutfeedSpinBox, ui->alprobefeedSpinBox };
486+
QSpinBox *spinBoxes[] = { ui->millfeedSpinBox, ui->drillfeedSpinBox, ui->cutfeedSpinBox, ui->cutvertfeedSpinBox, ui->alprobefeedSpinBox };
498487

499488
const unsigned int doubleSpinBoxesLen = sizeof(doubleSpinBoxes) / sizeof(doubleSpinBoxes[0]);
500489
const unsigned int spinBoxesLen = sizeof(spinBoxes) / sizeof(spinBoxes[0]);

mainwindow.h

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -54,7 +54,6 @@ class MainWindow : public QMainWindow
5454
private slots:
5555
void vectorialEnable(bool enable);
5656
void voronoiEnable(bool disable);
57-
void fillOutlineEnable(bool enable);
5857
void bridgesAvailable();
5958
void changeMetricInputUnits(bool metric);
6059
void startPcb2gcode();

0 commit comments

Comments
 (0)