Commit b13c5c9
authored
fix(ui): exclude unnamed tab labels from filter and groupBy field options (#9965)
### What?
Currently when showing available columns to filter on and group by it
will show fields inside tabs prepended with the tab name and an angle
bracket as separator.
### Why?
This current label makes sense when the tab has a name and also acts
like a group. But in my opinion it does not make sense when tab does not
have a name and is only used for presentational purposes. This shows
very well with the SEO plugin where the SEO fields are inside a group
field, so when used as a tab as well the SEO is shown double.
This makes the naming consistent with how we show columns in the list
view where unnamed tab has its fields hoisted.
### How?
Check for tab name and only include the tab label as prefix when the tab
has a name
### Before - inconsistency between column name and filter name


<img width="1343" height="609" alt="before groupby"
src="https://github.com/user-attachments/assets/5f2a0f0a-4500-4a94-8dd7-bd78fb057caf"
/>
### After - consistency between column name and filter name


<img width="1328" height="613" alt="after groupby"
src="https://github.com/user-attachments/assets/a6a6f2c3-290a-4688-b658-30364871806f"
/>1 parent ac16116 commit b13c5c9
3 files changed
Lines changed: 23 additions & 26 deletions
File tree
- packages/ui/src/utilities
- test
- access-control
- admin/e2e/list-view
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
66 | 66 | | |
67 | 67 | | |
68 | 68 | | |
69 | | - | |
70 | | - | |
71 | | - | |
| 69 | + | |
| 70 | + | |
| 71 | + | |
| 72 | + | |
| 73 | + | |
72 | 74 | | |
73 | 75 | | |
74 | 76 | | |
| |||
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
1222 | 1222 | | |
1223 | 1223 | | |
1224 | 1224 | | |
1225 | | - | |
| 1225 | + | |
1226 | 1226 | | |
1227 | 1227 | | |
1228 | 1228 | | |
1229 | 1229 | | |
1230 | 1230 | | |
1231 | | - | |
| 1231 | + | |
1232 | 1232 | | |
1233 | 1233 | | |
1234 | 1234 | | |
| |||
1392 | 1392 | | |
1393 | 1393 | | |
1394 | 1394 | | |
1395 | | - | |
| 1395 | + | |
1396 | 1396 | | |
1397 | 1397 | | |
1398 | 1398 | | |
1399 | 1399 | | |
1400 | | - | |
1401 | | - | |
1402 | | - | |
| 1400 | + | |
1403 | 1401 | | |
1404 | 1402 | | |
1405 | 1403 | | |
| |||
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
91 | 91 | | |
92 | 92 | | |
93 | 93 | | |
94 | | - | |
95 | | - | |
96 | | - | |
97 | | - | |
| 94 | + | |
| 95 | + | |
| 96 | + | |
| 97 | + | |
98 | 98 | | |
99 | 99 | | |
100 | 100 | | |
| |||
427 | 427 | | |
428 | 428 | | |
429 | 429 | | |
430 | | - | |
| 430 | + | |
431 | 431 | | |
432 | 432 | | |
433 | 433 | | |
434 | | - | |
| 434 | + | |
435 | 435 | | |
436 | 436 | | |
437 | 437 | | |
| |||
618 | 618 | | |
619 | 619 | | |
620 | 620 | | |
621 | | - | |
622 | | - | |
| 621 | + | |
623 | 622 | | |
624 | 623 | | |
625 | 624 | | |
| |||
696 | 695 | | |
697 | 696 | | |
698 | 697 | | |
699 | | - | |
| 698 | + | |
700 | 699 | | |
701 | 700 | | |
702 | 701 | | |
| |||
710 | 709 | | |
711 | 710 | | |
712 | 711 | | |
713 | | - | |
| 712 | + | |
714 | 713 | | |
715 | 714 | | |
716 | 715 | | |
| |||
721 | 720 | | |
722 | 721 | | |
723 | 722 | | |
724 | | - | |
| 723 | + | |
725 | 724 | | |
726 | 725 | | |
727 | 726 | | |
| |||
732 | 731 | | |
733 | 732 | | |
734 | 733 | | |
735 | | - | |
| 734 | + | |
736 | 735 | | |
737 | 736 | | |
738 | 737 | | |
| |||
781 | 780 | | |
782 | 781 | | |
783 | 782 | | |
784 | | - | |
| 783 | + | |
785 | 784 | | |
786 | 785 | | |
787 | 786 | | |
| |||
797 | 796 | | |
798 | 797 | | |
799 | 798 | | |
800 | | - | |
801 | | - | |
802 | | - | |
| 799 | + | |
803 | 800 | | |
804 | | - | |
| 801 | + | |
805 | 802 | | |
806 | 803 | | |
807 | 804 | | |
| |||
0 commit comments