create/destroy settings form dynamically instead of always keeping it in memory

Author: p0358

CodeStats/CodeStatsPackage.cs

@@ -109,10 +109,6 @@ private static void InitializeAsync()
                 currentPulse = new Pulse();
 
                 Logger.Info("Initialing settings form...");
-                // Settings Form
-                _settingsForm = new CodeStats.Forms.SettingsForm();
-                _settingsForm.ConfigSaved += SettingsFormOnConfigSaved;
-                Logger.Info("Initialized settings form"); // it takes 5 seconds to get here from Initializing Code::Stats message...
 
                 // Load config file
                 _CodeStatsConfigFile = new ConfigFile();
@@ -515,9 +511,8 @@ private static Task ProcessPulses(CancellationTokenSource tokenSource)
                                         Logger.Error("Could not pulse (error 404). The entered custom endpoint (" + URL + ") is invalid. ", ex);
                                         MessageBox.Show("Could not pulse. Invalid API endpoint URL. Please make sure you entered a valid API URL in Code::Stats settings or delete the value altogether to restore the default.\nAll recorded XP from this session will be lost if you do not provide the correct API URL path!", "Code::Stats – error 404", MessageBoxButtons.OK, MessageBoxIcon.Error);
 
-                                        _settingsForm.FocusTxtAPIURL();
-                                        _settingsForm.ShowAPIURLTooltip();
                                         SettingsPopup();
+                                        _settingsForm.FocusTxtAPIURL();
                                         _settingsForm.ShowAPIURLTooltip();
                                     }
                                     else
@@ -707,11 +702,6 @@ public static bool EnoughTimePassed(DateTime now)
             return _lastActivity < now.AddMilliseconds(-1 * pulseFrequency) && _lastPulse < now.AddMilliseconds(-1 * pulseFrequency);
         }
 
-        private static void SettingsFormOnConfigSaved(object sender, EventArgs eventArgs)
-        {
-            GetSettings();
-        }
-
         public static void GetSettings(bool skipRead = false)
         {
             if (!skipRead) _CodeStatsConfigFile.Read();
@@ -736,10 +726,23 @@ private static void PromptApiKey()
 
         private static void SettingsPopup()
         {
-            _settingsForm.Visible = false;
+            if (_settingsForm == null)
+            {
+                _settingsForm = new CodeStats.Forms.SettingsForm();
+                _settingsForm.OnConfigSaved += SettingsFormOnConfigSaved;
+            }
+            //_settingsForm.Visible = false; // ?
             _settingsForm.ShowDialog();
         }
 
+        private static void SettingsFormOnConfigSaved(object sender, EventArgs eventArgs)
+        {
+            GetSettings();
+            _settingsForm.OnConfigSaved -= SettingsFormOnConfigSaved;
+            _settingsForm.Dispose();
+            _settingsForm = null;
+        }
+
         public static void ReportStats()
         {
             Task.Run(() =>

CodeStats/Forms/SettingsForm.cs

@@ -8,7 +8,7 @@ namespace CodeStats.Forms
     public partial class SettingsForm : Form
     {
         private readonly ConfigFile _CodeStatsConfigFile;
-        internal event EventHandler ConfigSaved;
+        internal event EventHandler OnConfigSaved;
         private ToolTip apiurlToolTip;
 
         public SettingsForm()
@@ -35,6 +35,7 @@ private void SettingsForm_Load(object sender, EventArgs e)
                 {
                     txtAPIURL.Text = _CodeStatsConfigFile.ApiUrl;
                 }
+                LanguageDetectionUIRefresh();
             }
             catch (Exception ex)
             {
@@ -101,16 +102,13 @@ private void btnOk_Click(object sender, EventArgs e)
 
                     _CodeStatsConfigFile.Save();
 
-                    OnConfigSaved();
-                    //CodeStatsPackage.GetSettings(); // reload settings in main class
-
                     CodeStatsPackage._hasAlreadyShownInvalidApiTokenMessage = false;
-
                     if (chkStats.Checked && !CodeStatsPackage._reportedStats)
                     {
                         CodeStatsPackage.ReportStats();
                     }
 
+                    NotifyOnConfigSaved(); // it destroys the settings form in the handler
                 /*}
                 else // - kept in case we check API tokens in future
                 {
@@ -125,9 +123,9 @@ private void btnOk_Click(object sender, EventArgs e)
             }
         }
 
-        protected virtual void OnConfigSaved()
+        protected virtual void NotifyOnConfigSaved()
         {
-            var handler = ConfigSaved;
+            var handler = OnConfigSaved;
             if (handler != null) handler(this, EventArgs.Empty);
         }