osm2pgsql-replication: run against installed osm2pgsql

When installing osm2pgsql-replication run the script per default
against osm2pgsql in the same directory. This avoids potential
security issues through PATH manipulation.

Author: lonvia

CMakeLists.txt

@@ -332,8 +332,11 @@ add_subdirectory(docs)
 # Install
 #############################################################
 
+include(GNUInstallDirs)
+
 if (ENABLE_INSTALL)
     install(TARGETS osm2pgsql DESTINATION bin)
-    install(PROGRAMS scripts/osm2pgsql-replication DESTINATION bin)
     install(FILES default.style empty.style DESTINATION share/osm2pgsql)
+    install(CODE "set(OSM2PGSQL_BINDIR ${CMAKE_INSTALL_FULL_BINDIR})
+                  configure_file(${PROJECT_SOURCE_DIR}/scripts/osm2pgsql-replication ${CMAKE_INSTALL_FULL_BINDIR}/osm2pgsql-replication)")
 endif()

scripts/osm2pgsql-replication

@@ -51,6 +51,10 @@ except ImportError:
 
 LOG = logging.getLogger()
 
+# Will be replaced when installed via CMake.
+INSTALL_PREFIX = '@OSM2PGSQL_BINDIR@/'
+if INSTALL_PREFIX.startswith('@'):
+    INSTALL_PREFIX = ''
 
 def pretty_format_timedelta(seconds):
     minutes = int(seconds/60)
@@ -484,8 +488,8 @@ def get_parser():
                      help='File to save changes before they are applied to osm2pgsql.')
     cmd.add_argument('--max-diff-size', type=int, default=500,
                      help='Maximum data to load in MB (default: 500MB)')
-    cmd.add_argument('--osm2pgsql-cmd', default='osm2pgsql',
-                     help='Path to osm2pgsql command (default: osm2pgsql)')
+    cmd.add_argument('--osm2pgsql-cmd', default=INSTALL_PREFIX + 'osm2pgsql',
+                     help=f'Path to osm2pgsql command (default: {INSTALL_PREFIX}osm2pgsql)')
     cmd.add_argument('--once', action='store_true',
                      help='Run updates only once, even when more data is available.')
     cmd.add_argument('--post-processing', metavar='SCRIPT',