Use data() instead of taking the address of the 0-th element

Author: joto

src/output-flex.cpp

@@ -217,7 +217,7 @@ static void push_osm_object_to_lua_stack(lua_State *lua_state,
                 lua_createtable(lua_state, 0, 3);
                 std::array<char, 2> tmp{"x"};
                 tmp[0] = osmium::item_type_to_char(member.type());
-                luaX_add_table_str(lua_state, "type", &tmp[0]);
+                luaX_add_table_str(lua_state, "type", tmp.data());
                 luaX_add_table_int(lua_state, "ref", member.ref());
                 luaX_add_table_str(lua_state, "role", member.role());
             });

src/wkb.cpp

@@ -428,7 +428,7 @@ class ewkb_parser_t
         check_bytes(sizeof(double) * 2);
 
         std::array<double, 2> data{};
-        std::memcpy(&data[0], m_it, sizeof(double) * 2);
+        std::memcpy(data.data(), m_it, sizeof(double) * 2);
         m_it += sizeof(double) * 2;
 
         point->set_x(data[0]);

tests/test-options-parse.cpp

@@ -21,21 +21,21 @@ static void bad_opt(std::vector<char const *> opts, char const *msg)
 {
     opts.insert(opts.begin(), "osm2pgsql");
     opts.push_back(TEST_PBF);
-    REQUIRE_THROWS_WITH(options_t((int)opts.size(), (char **)&opts[0]),
+    REQUIRE_THROWS_WITH(options_t((int)opts.size(), (char **)opts.data()),
                         Catch::Matchers::Contains(msg));
 }
 
 static options_t opt(std::vector<char const *> opts)
 {
     opts.insert(opts.begin(), "osm2pgsql");
     opts.push_back(TEST_PBF);
-    return options_t((int)opts.size(), (char **)&opts[0]);
+    return options_t((int)opts.size(), (char **)opts.data());
 }
 
 TEST_CASE("Insufficient arguments", "[NoDB]")
 {
     std::vector<char const *> opts = {"osm2pgsql", "-a", "-c", "--slim"};
-    REQUIRE_THROWS_WITH(options_t((int)opts.size(), (char **)&opts[0]),
+    REQUIRE_THROWS_WITH(options_t((int)opts.size(), (char **)opts.data()),
                         Catch::Matchers::Contains("Missing input"));
 }