Skip to content

Commit 4568836

Browse files
committed
Use parameter name "args" instead of the strangly named "tags"
1 parent 136dfa1 commit 4568836

1 file changed

Lines changed: 14 additions & 14 deletions

File tree

src/logging.hpp

Lines changed: 14 additions & 14 deletions
Original file line numberDiff line numberDiff line change
@@ -40,7 +40,7 @@ class logger
4040
template <typename S, typename... TArgs>
4141
void log(log_level with_level, char const *prefix,
4242
fmt::text_style const &style, S const &format_str,
43-
TArgs &&... tags) const
43+
TArgs &&... args) const
4444
{
4545
if (with_level < m_current_level) {
4646
return;
@@ -59,7 +59,7 @@ class logger
5959
str += fmt::format(ts, "{}: ", prefix);
6060
}
6161

62-
str += fmt::format(ts, format_str, std::forward<TArgs>(tags)...);
62+
str += fmt::format(ts, format_str, std::forward<TArgs>(args)...);
6363
str += '\n';
6464

6565
std::fputs(str.c_str(), stderr);
@@ -98,51 +98,51 @@ class logger
9898
logger &get_logger() noexcept;
9999

100100
template <typename S, typename... TArgs>
101-
void log_debug(S const &format_str, TArgs &&... tags)
101+
void log_debug(S const &format_str, TArgs &&... args)
102102
{
103103
get_logger().log(log_level::debug, nullptr, {}, format_str,
104-
std::forward<TArgs>(tags)...);
104+
std::forward<TArgs>(args)...);
105105
}
106106

107107
template <typename S, typename... TArgs>
108-
void log_info(S const &format_str, TArgs &&... tags)
108+
void log_info(S const &format_str, TArgs &&... args)
109109
{
110110
get_logger().log(log_level::info, nullptr, {}, format_str,
111-
std::forward<TArgs>(tags)...);
111+
std::forward<TArgs>(args)...);
112112
}
113113

114114
template <typename S, typename... TArgs>
115-
void log_warn(S const &format_str, TArgs &&... tags)
115+
void log_warn(S const &format_str, TArgs &&... args)
116116
{
117117
get_logger().log(log_level::warn, "WARNING", fg(fmt::color::red),
118-
format_str, std::forward<TArgs>(tags)...);
118+
format_str, std::forward<TArgs>(args)...);
119119
}
120120

121121
template <typename S, typename... TArgs>
122-
void log_error(S const &format_str, TArgs &&... tags)
122+
void log_error(S const &format_str, TArgs &&... args)
123123
{
124124
get_logger().log(log_level::error, "ERROR",
125125
fmt::emphasis::bold | fg(fmt::color::red), format_str,
126-
std::forward<TArgs>(tags)...);
126+
std::forward<TArgs>(args)...);
127127
}
128128

129129
template <typename S, typename... TArgs>
130-
void log_sql(S const &format_str, TArgs &&... tags)
130+
void log_sql(S const &format_str, TArgs &&... args)
131131
{
132132
auto const &logger = get_logger();
133133
if (logger.log_sql()) {
134134
logger.log(log_level::error, "SQL", fg(fmt::color::blue), format_str,
135-
std::forward<TArgs>(tags)...);
135+
std::forward<TArgs>(args)...);
136136
}
137137
}
138138

139139
template <typename S, typename... TArgs>
140-
void log_sql_data(S const &format_str, TArgs &&... tags)
140+
void log_sql_data(S const &format_str, TArgs &&... args)
141141
{
142142
auto const &logger = get_logger();
143143
if (logger.log_sql_data()) {
144144
logger.log(log_level::error, "SQL", {}, format_str,
145-
std::forward<TArgs>(tags)...);
145+
std::forward<TArgs>(args)...);
146146
}
147147
}
148148

0 commit comments

Comments
 (0)